Date: Tue, 2 Sep 2003 01:00:33 -0700 (PDT) From: "Jason Young" <jyoung8607@hotmail.com> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/46672: dump(8) program gives unnecessary -L warning Message-ID: <200309020800.h8280Xhs080048@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/46672; it has been noted by GNATS.
From: "Jason Young" <jyoung8607@hotmail.com>
To: freebsd-gnats-submit@FreeBSD.org, swear@attbi.com
Cc:
Subject: Re: bin/46672: dump(8) program gives unnecessary -L warning
Date: Tue, 02 Sep 2003 02:58:54 -0500
A better patch: improve error handling, and update documentation.
*** main.c Tue Sep 2 02:48:03 2003
--- main.c.orig Tue Sep 2 01:26:49 2003
***************
*** 311,330 ****
}
spcl.c_dev[NAMELEN-1]='\0';
spcl.c_filesys[NAMELEN-1]='\0';
if ((mntpt = getmntpt(disk, &mntflags)) != 0) {
! if (mntflags & MNT_RDONLY) {
! if(snapdump == 1) {
! msg("WARNING: %s\n",
! "-L ignored for read-only filesystem.");
! snapdump = 0;
! }
! }
! else if (snapdump == 0) {
msg("WARNING: %s\n",
! "should use -L when dumping live r/w
filesystems!");
} else {
struct ufs_args args;
char snapname[BUFSIZ];
snprintf(snapname, sizeof snapname,
"%s/.dump_snapshot",
--- 311,323 ----
}
spcl.c_dev[NAMELEN-1]='\0';
spcl.c_filesys[NAMELEN-1]='\0';
if ((mntpt = getmntpt(disk, &mntflags)) != 0) {
! if (snapdump == 0) {
msg("WARNING: %s\n",
! "should use -L when dumping live filesystems!");
} else {
struct ufs_args args;
char snapname[BUFSIZ];
snprintf(snapname, sizeof snapname,
"%s/.dump_snapshot",
fury#
*** dump.8.orig Tue Sep 2 02:12:53 2003
--- dump.8 Tue Sep 2 02:54:39 2003
***************
*** 211,220 ****
--- 211,222 ----
To obtain a consistent dump image,
.Nm
takes a snapshot of the file system and
then does a dump of the snapshot.
The snapshot is removed when the dump is complete.
+ This option is disregarded for unmounted or read-only
+ mounted filesystems.
.It Fl n
Whenever
.Nm
requires operator attention,
notify all operators in the group
_________________________________________________________________
MSN 8: Get 6 months for $9.95/month. http://join.msn.com/?page=dept/dialup
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200309020800.h8280Xhs080048>