Date: Mon, 9 Apr 2018 07:17:33 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: "Roger Pau Monn?" <royger@freebsd.org> Cc: rgrimes@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r332092 - in head/sys: amd64/amd64 sys x86/x86 Message-ID: <201804091417.w39EHXUH018893@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <20180409083554.k34hfijxiztwdne6@MacBook-Pro-de-Roger.local>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Fri, Apr 06, 2018 at 09:17:09AM -0700, Rodney W. Grimes wrote: > > [ Charset UTF-8 unsupported, converting... ] > > > Author: royger > > > Date: Fri Apr 6 11:20:06 2018 > > > New Revision: 332092 > > > URL: https://svnweb.freebsd.org/changeset/base/332092 > > > > > > Log: > > > remove GiB/MiB macros from param.h > > > > > > And instead define them in the files where they are used. > > > > It would of been better to "revert" your prior change and > > make a seperate new commit. It is rarely desireable to combine > > a revert of a change with anything. > > A plain revert of r332072 would have left the tree in a broken state, > because r332073 depends on those macros. IMO it's better to have a > buildable tree at all times in order for it to be bisectable. Well a revert of r332073 could of been combined leaving the tree building, and in the state before the attempt to do {MG}iB() macros. -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201804091417.w39EHXUH018893>