Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 21 Jun 2013 15:02:00 -0400
From:      Mark Johnston <markj@freebsd.org>
To:        Jeff Ford <jeff.ford@gmail.com>
Cc:        freebsd-dtrace@freebsd.org
Subject:   Re: Patch for the trap handler and some test list sanity
Message-ID:  <CAMw1wOyHxDw13zUBcxpcp_UmzbZ44z7KdmNOnD6EtjUQZByq7A@mail.gmail.com>
In-Reply-To: <20130622070025.GA14663@charmander.mks.com>
References:  <CAJ0x7rOiY_6z_1obs4N78EPh%2B_prWAVSgCSvywBZb%2BZBZ0342g@mail.gmail.com> <20130622070025.GA14663@charmander.mks.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jun 22, 2013 at 3:00 AM, Mark Johnston <markj@freebsd.org> wrote:
> On Fri, Jun 21, 2013 at 11:47:43AM -0700, Jeff Ford wrote:
>> Anton Rang and I did some DTrace work for Isilon that we're trying to ge=
t
>> back into FreeBSD, but neither of us is a committer - here's the first o=
ne.
>>
>> This moves the check for dtrace trap handlers into the low-level excepti=
on
>> handler to prevent recursive entry when the trap routine is instrumented=
.
>> This fixes several tests which previously panicked including
>> cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/safety/tst.basename.=
d.
>> The fix is AMD64 only =96 neither of us has had time to make changes to =
i386
>> code as we don=92t use it here.
>>
>> Also this includes updates to the Makefile for the DTrace tests to
>> categorize which ones pass, which ones fail, which ones aren=92t safe to=
 run
>> at all, and which ones sometimes pass and sometimes fail. The list shoul=
d
>> be correct for both AMD64 and i386. This makes =93make=94, =93make ignor=
e=94, and
>> =93make flaky=94 safe to run in /tools/test/dtrace.
>
> Hello,
>
> I'd be happy to help bring these in. I'll probably need some help
> reviewing the first one, but "improve the DTrace test makefile" has been
> on my todo list for a while.
>
> Are they available somewhere?

Sorry, didn't see the attachment. I'll take a look tonight.

-Mark



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMw1wOyHxDw13zUBcxpcp_UmzbZ44z7KdmNOnD6EtjUQZByq7A>