Date: Sun, 16 Mar 2008 23:15:58 -0700 From: Gregory Shapiro <gshapiro@freebsd.org> To: Mike Telahun Makonnen <mtm@freebsd.org> Cc: Giorgos Keramidas <keramida@ceid.upatras.gr>, current@freebsd.org Subject: Re: latest rc.subr breaks etc/rc.d/sendmail Message-ID: <20080317061558.GA1220@monkeyboy.local> In-Reply-To: <584bfc3f0803122336r96f4033pc0e25a7324fb0486@mail.gmail.com> References: <20080202012707.GA1800@kobe.laptop> <1204809780.885.3.camel@sol> <20080306201905.GA11317@kobe.laptop> <20080311025333.GF2422@monkeyboy.local> <584bfc3f0803122336r96f4033pc0e25a7324fb0486@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> Can you take a look at the following patch please? The patch looks good, I just found some minor issues: 1. In /etc/rc.d/sendmail, rename sendmail_precmd to sendmail_prestart for consistency? 2. /etc/rc.d/sendmail-msp-queue doesn't need to set start_precmd or define a sendmail_prestart() function as the MSP queue runner doesn't use the aliases file (yes, this was a bug in the old /etc/rc.d/sendmail). 3. Both /etc/rc.d/sendmail-outbound and /etc/rc.d/sendmail-submit are missing: required_files="/etc/mail/sendmail.cf" (yes, this was also a bug in the old /etc/rc.d/sendmail). 4. Putting sendmail.subr in /etc/mail/ seems a bit odd. /etc/mail/ is meant for MTA configuration, not startup subroutines. Perhaps /etc/rc.sendmail.subr or /etc/sendmail.subr for consistency with /etc/network.subr? 5. This line in /etc/defaults/rc.conf: # Settings for /etc/rc.sendmail and /etc/rc.d/sendmail: should be updated to: # Settings for /etc/rc.sendmail and /etc/rc.d/sendmail*:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080317061558.GA1220>