Date: Thu, 20 Apr 2000 04:40:02 -0700 (PDT) From: Alexander Langer <alex@big.endian.de> To: freebsd-bugs@FreeBSD.org Subject: Re: misc/18109: if pw_shell is empty(/bin/sh is assumed), cannot login via ssh. Message-ID: <200004201140.EAA42860@freefall.freebsd.org>
index | next in thread | raw e-mail
The following reply was made to PR misc/18109; it has been noted by GNATS.
From: Alexander Langer <alex@big.endian.de>
To: noroi@mob.or.jp
Cc: freebsd-gnats-submit@FreeBSD.ORG
Subject: Re: misc/18109: if pw_shell is empty(/bin/sh is assumed), cannot login via ssh.
Date: Thu, 20 Apr 2000 13:31:07 +0200
Thus spake noroi@mob.or.jp (noroi@mob.or.jp):
> + if (pw->pw_shell[0] != '\0') {
> /* deny if shell does not exists or is not executable */
> if (stat(pw->pw_shell, &st) != 0)
> return 0;
> if (!((st.st_mode & S_IFREG) && (st.st_mode & (S_IXOTH|S_IXUSR|S_IXGRP))))
> return 0;
> + }
You should add indentation to make your code more readable.
What will happen if it is == 0 now?
Alex
--
I need a new ~/.sig.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message
help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200004201140.EAA42860>