Date: Sun, 20 Jun 2004 23:36:15 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Ruslan Ermilov <ru@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/mk bsd.kmod.mk Message-ID: <20040620213615.GQ12007@darkness.comp.waw.pl> In-Reply-To: <20040618164732.GB16260@ip.net.ua> References: <200406181638.i5IGch7K079518@repoman.freebsd.org> <20040618164732.GB16260@ip.net.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--B2gdd0vZVCwxSorY
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Fri, Jun 18, 2004 at 07:47:33PM +0300, Ruslan Ermilov wrote:
+> On Fri, Jun 18, 2004 at 04:38:43PM +0000, Pawel Jakub Dawidek wrote:
+> > pjd 2004-06-18 16:38:43 UTC
+> >=20
+> > FreeBSD src repository
+> >=20
+> > Modified files:
+> > share/mk bsd.kmod.mk=20
+> > Log:
+> > Check if ${_dir}/kern exists as well, because if it doesn't exists
+> > we will fail later and we can miss good kernel source tree directory.
+> > I found this trying to compile kld module and it finds 'conf/kmod.mk'
+> > in '../..', but it fails later, because there is no 'kern' directory,
+> > but there is valid kernel source tree still in /usr/src/sys/.
+> > =20
+> > Revision Changes Path
+> > 1.89 +2 -2 src/share/mk/bsd.kmod.mk
+> >=20
+> It fixes just one out of dozen other possibilities of partial checkouts.
Yes, but there are two checks:
For (...)
If exists(${_dir}/conf/<something>)
Ok.
EndIf
EndFor
If !exists(${_dir}/conf) || !exists(${_dir}/kern)
Bad.
EndIf
So IMHO we should check two directories in both places or one directory
in both places, but not one here and two there.
Does it make sense to you?
--=20
Pawel Jakub Dawidek http://www.FreeBSD.org
pjd@FreeBSD.org http://garage.freebsd.pl
FreeBSD committer Am I Evil? Yes, I Am!
--B2gdd0vZVCwxSorY
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (FreeBSD)
iD8DBQFA1gNPForvXbEpPzQRAvgjAJ9n77dQ7VipW6a0Sgb9A9FlxIUASACgtnI/
3YPQHTBLYGB02KLDVVNG+AU=
=FPzj
-----END PGP SIGNATURE-----
--B2gdd0vZVCwxSorY--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040620213615.GQ12007>