Date: Wed, 9 Jan 2013 17:08:23 -0700 From: Warner Losh <imp@bsdimp.com> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Jaakko Heinonen <jh@freebsd.org>, src-committers@freebsd.org, pjd@freebsd.org, John Baldwin <jhb@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org, imp@freebsd.org Subject: Re: svn commit: r244585 - in head: . sys/geom/label Message-ID: <A20D24C1-3DF7-4D3D-8DE6-13E0AE2DF4C6@bsdimp.com> In-Reply-To: <20130109234526.GL2561@kib.kiev.ua> References: <201212221343.qBMDhCHa086834@svn.freebsd.org> <201301070927.07157.jhb@freebsd.org> <20130108193146.GA1815@a91-153-116-96.elisa-laajakaista.fi> <201301091417.37451.jhb@freebsd.org> <20130109234526.GL2561@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jan 9, 2013, at 4:45 PM, Konstantin Belousov wrote: > On Wed, Jan 09, 2013 at 02:17:37PM -0500, John Baldwin wrote: >> On Tuesday, January 08, 2013 2:31:47 pm Jaakko Heinonen wrote: >>> On 2013-01-07, John Baldwin wrote: >>>> I think if it isn't hard to do so, we should aim to preserve labels = as they=20 >>>> are generally intended to be human readable as-is. Just preserving = spaces is=20 >>>> probably sufficient for this as they are probably the most commonly = used=20 >>>> character in labels affected by this change. >>>=20 >>> All right. I have prepared patches for review. >>>=20 >>> - Quote device names in devctl(4) device events. This allows events = to >>> work for device names containing spaces. >>> - Allow spaces again in device names. >>>=20 >>> Requested by: jhb >>> PR: kern/161912 >>=20 >> Thanks. I think your patches look fine as far as I can tell. >=20 > I do not object, but IMHO having names with the spaces in /dev is = weird > and possibly problematic. This was the reason of my initial request to > disable spaces, together with the fact that it changes the devctl(4) > protocol (there might be other /dev/devctl readers besides devd). I'm not sure that the protocol changes are quire right yet... Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A20D24C1-3DF7-4D3D-8DE6-13E0AE2DF4C6>