Date: Wed, 21 Jun 2006 10:56:25 +0100 From: Florent Thoumie <flz@FreeBSD.org> To: Yar Tikhiy <yar@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/etc rc.subr src/share/man/man8 rc.subr.8 Message-ID: <1150883785.3467.4.camel@mayday.esat.net> In-Reply-To: <200606210942.k5L9gtAi060504@repoman.freebsd.org> References: <200606210942.k5L9gtAi060504@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Wed, 2006-06-21 at 09:42 +0000, Yar Tikhiy wrote: > yar 2006-06-21 09:42:55 UTC > > FreeBSD src repository > > Modified files: > etc rc.subr > share/man/man8 rc.subr.8 > Log: > Quite a number of rc.d scripts try to load kernel modules. Many > of them do that conditionally depending on kldstat. The code is > duplicated all over, but bugs can be uniqie. > > To make the things more consistent, introduce a new rc.subr function, > load_kld, which takes care of loading a kernel module conditionally. > > (Found this lying for a while in my p4 branch for various hacks.) I added such a function some weeks ago (far more simple though). Talking with pjd, I've backed it out to use the somewhat straight-forward method he used in rc.d/geli. I don't have a particular feeling against your function but it uses commands that may not be available early enough (getopt, egrep). While it's easy to remove the getopt dependency (see rc.d/mdconfig), it's not the case for egrep. -- Florent Thoumie flz@FreeBSD.org FreeBSD Committer [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQBEmRfJMxEkbVFH3PQRAk+FAJ9T41KHXrh90lEgHPccb3hGYJglrwCggGU1 laPLvVeFVz5VXva11KFPHmc= =ThxQ -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1150883785.3467.4.camel>