Date: Tue, 6 Jun 2017 00:41:30 +0000 From: Brooks Davis <brooks@freebsd.org> To: Miles Fertel <milesfertel@college.harvard.edu> Cc: soc-status@freebsd.org Subject: Re: Week 1 Update: Mergesort Tests Message-ID: <20170606004130.GC14665@spindle.one-eyed-alien.net> In-Reply-To: <CADoeuZ8S=Jxf7b9F7C8Hq5H9Tp95EFRQbXMf9BAWPm8Pan%2B1ZQ@mail.gmail.com> References: <CADoeuZ8S=Jxf7b9F7C8Hq5H9Tp95EFRQbXMf9BAWPm8Pan%2B1ZQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--YiEDa0DAkWCtVeE4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable I got an invite from github, but even when I was definitely logged in, I got 404 errors accessing it. As a practical matter, your repo needs to be public as that's part of the terms from Google. -- Brooks On Mon, Jun 05, 2017 at 09:53:00AM -0400, Miles Fertel wrote: > Hey Brooks, >=20 > Just wanted to let you know that I've pushed my first week of work to the > github repo and added you as a collaborator. I've submitted a pull request > from the dev branch to the master and started a review with a question or > two. >=20 > I've edited mergesort_test.c to have a good first implementation, includi= ng > tests for: >=20 > - Trivial arrays > - Sorted arrays > - Partially sorted arrays > - Randomly generated arrays > - Arrays with char elements >=20 > I've built this up on top of the previous implementation, so the Kyuafile > is the same. I ran the implementation locally with atf and kyua and the > current mergesort behaves as expected, succeeding all all tests except for > the small element test. When my improved algorithm is complete, that shou= ld > pass as well. >=20 > Please let me know if there's anything I could improve. >=20 > - Miles --YiEDa0DAkWCtVeE4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJZNfo6AAoJEKzQXbSebgfArykH/izzkt73Smuqrz8fPJ0ud83Y TKCHWzPGlW8KjMwjMZ2klRU59b0V2y25xchqcgo5Pou7mC5iC3cdj0TSpIsqgiRD YuXY7w+EFJyAKx9Kk1nNtC8jdwzwJ1yrIjB3inFNsW9VC+vq3ZUaiIUo/yCQfslP qW8km1Ee0QmkDItYHVr5vCylUzRjde3QUJM5UgsX+jag5uPt+3jSatksJed6JpzX 9H7LFkr+NndJzH8us9qFm7Z+U/NrruSKIKKXygZ82G9MD0uWEOzDfIRWF3v2ZXw7 OBnnEw0yN+sUtmBt8Hh9R+SIF+TWc4fUJ8LHrQhZqlWgMOgXCgjNVunmlcXrfWg= =7C3I -----END PGP SIGNATURE----- --YiEDa0DAkWCtVeE4--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20170606004130.GC14665>