Date: Fri, 4 Sep 2020 20:57:25 -0600 From: Warner Losh <imp@bsdimp.com> To: Mark Linimon <linimon@lonesome.com> Cc: Andrew Gallatin <gallatin@cs.duke.edu>, Alexey Dokuchaev <danfe@freebsd.org>, Michael Tuexen <tuexen@fh-muenster.de>, Pedro Giffuni <pfg@freebsd.org>, Mateusz Guzik <mjg@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r365071 - in head/sys: net net/altq net/route net80211 netgraph netgraph/atm netgraph/atm/ccatm netgraph/atm/sscfu netgraph/atm/sscop netgraph/atm/uni netgraph/bluetooth/common netgraph... Message-ID: <CANCZdfo8km1ahTSajJpLhyFyYyQsPr-ZwMWRZx_jmLGdRpc=WA@mail.gmail.com> In-Reply-To: <20200905010510.GA26297@lonesome.com> References: <202009012119.081LJERb018106@repo.freebsd.org> <95844C00-D10A-456D-AD29-DF572043074F@fh-muenster.de> <20200902020507.GA38274@FreeBSD.org> <eba32e79-4b90-ecce-7bbb-455f691d4444@FreeBSD.org> <20200902180626.GA88595@FreeBSD.org> <6124a908-25a5-e023-16da-7963ba229b7f@FreeBSD.org> <08636D5E-AA07-4AE7-B5AC-656B08CF564B@fh-muenster.de> <20200903024226.GA54078@FreeBSD.org> <60ea593f-8258-e30d-b897-f162168b44d3@cs.duke.edu> <20200905010510.GA26297@lonesome.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Sep 4, 2020, 7:05 PM Mark Linimon <linimon@lonesome.com> wrote: > On Fri, Sep 04, 2020 at 02:15:04PM -0400, Andrew Gallatin wrote: > > and I also anticipate it will cause problems with MFCs > > And existing PRs and DRs. > Or we could just not bother we these changes at all. It's a pipe dream we will ever be style(9) compliant in all our code, or that we can magically have a tool to enforce in new commits. We have better things to worry about. We should continue to ignore this non problem and for new users point them at the 95% correct format thing to run their submitted patches if they submit something too far out of whack. The last sweep deleted a boatload of blank lines that were in there on purpose. Not worth adding them back, but still annoying to no real benefit. I just don't see the benefits at all of doing anything here. The few reviews that I've seen mention it seem to be the right level of effort. Warner >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfo8km1ahTSajJpLhyFyYyQsPr-ZwMWRZx_jmLGdRpc=WA>