Date: Sun, 5 Jul 2015 13:49:06 -0700 From: Garrett Cooper <yaneurabeya@gmail.com> To: Ian Lepore <ian@FreeBSD.org> Cc: John-Mark Gurney <jmg@funkthat.com>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r285160 - head/sys/conf Message-ID: <495E11C2-BB42-4687-8551-604C1F14D37E@gmail.com> In-Reply-To: <1436126730.1191.4.camel@freebsd.org> References: <201507051415.t65EFxWd044357@repo.freebsd.org> <20150705194954.GA8523@funkthat.com> <1436126730.1191.4.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Jul 5, 2015, at 13:05, Ian Lepore <ian@FreeBSD.org> wrote: > On Sun, 2015-07-05 at 12:49 -0700, John-Mark Gurney wrote: >> Ian Lepore wrote this message on Sun, Jul 05, 2015 at 14:15 +0000: >>> Author: ian >>> Date: Sun Jul 5 14:15:58 2015 >>> New Revision: 285160 >>> URL: https://svnweb.freebsd.org/changeset/base/285160 >>> >>> Log: >>> Ensure all the required files get built when you include the IPSEC option. >> >> Umm.. This looks more like that IPSEC should require that the crypto >> device be specified instead of fixing it this way... > > I considered that, but rejected it given the presence of crypto | ipsec > on some of the files already, but not a sufficiency of them to actually > build sucessfully. Heavily my thinking that was a personal belief that > if you say "option foo" it should just work without you needing to know > other (likely not well documented) prerequisite options also need to be > set. Or… just create a manpage that says “options IPSEC” requires “device crypto”? [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJVmZhCAAoJEMZr5QU6S73eSZoH/R+MKFsLH8slqXxWmzU72vfJ wxJ+oEI72TSbg7Dv8dY4G2kded4zImmnikqVqUcdrheG2Y2mxmYq77z4MhMY2Yky v6TIegkca2NekA3n+r4FxCOC4uXN3enEvWDxCt3co5QrbQmy61bYw8ELQtTj6HpY bGiV1T5hZL69gzKILrCJ8Vi8QbvSDBa5mysxMJ4vYITNKliG7n72dxko7DmIZGvY VM+M/AjmWpzsGuZVg3wF+F0LBZwijraM66k4sFuGtj72szkaPa+ewFAxmUidBi8t WBY5tJu+Yp2iyREP6TxmSuUT+nC3+erQmEeIXlRh05iEQL1C3fAop06EQP3wovI= =iagf -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?495E11C2-BB42-4687-8551-604C1F14D37E>