Date: Sat, 18 Nov 2000 21:11:24 +0100 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: David Malone <dwmalone@maths.tcd.ie> Cc: current@freebsd.org Subject: Re: Typo in labpc.c Message-ID: <33162.974578284@critter> In-Reply-To: Your message of "Sat, 18 Nov 2000 17:23:16 GMT." <200011181723.aa82033@salmon.maths.tcd.ie>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <200011181723.aa82033@salmon.maths.tcd.ie>, David Malone writes:
>I noticed the following while looking through the M_ZERO patches.
>When you were cleaning up some dev stuff you made the following
>change to labpc.c (revision 1.33):
>
>
> labpcs = malloc(NLABPC * sizeof(struct ctlr *), M_DEVBUF, M_NOWAIT);
> if (labpcs)
> {
> bzero(labpcs, NLABPC * sizeof(struct ctlr *));
> return 1;
> }
>+ cdevsw_add(&labpc_cdevsw);
> return 0;
> }
>
>This seems to only do the cdevsw_add if the malloc failed. I presume
>this is the opposit of the intended sense. I'll fix it up if you also
>think it looks wrong.
If nobody have noticed in "17 months, 2 weeks ago" (as cvs-web says)
that labpc doesn't work, the labpc driver should be killed, not fixed.
Objections ?
--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?33162.974578284>