Date: Sat, 11 Mar 2017 19:06:02 -0800 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Ian Lepore <ian@FreeBSD.org> Cc: "Rodney W. Grimes" <rgrimes@FreeBSD.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r315091 - head/share/termcap Message-ID: <0EAE6C58-4573-4A71-97C8-0D672C814945@gmail.com> In-Reply-To: <1489287453.40576.75.camel@freebsd.org> References: <201703120037.v2C0bjdq045397@repo.freebsd.org> <1489287453.40576.75.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
> On Mar 11, 2017, at 18:57, Ian Lepore <ian@FreeBSD.org> wrote:
…
> In an arm build sandbox I ran "make distribution DESTDIR=/tmp/ian" and
> this is what happened with termcap:
>
> --- etc-termcap ---
> install -l rs /usr/share/misc/termcap /tmp/ian/etc/termcap
> ...
> revolution > file /tmp/ian/etc/termcap
> /tmp/ian/etc/termcap: symbolic link to ../../../usr/share/misc/termcap
>
>
> Then I changed the rsymlink in share/termcap/Makefile to:
>
> ${INSTALL_RSYMLINK} ${DESTDIR}/${BINDIR}/misc/termcap ${DESTDIR}/etc/termcap
>
> and it did the right thing:
>
> --- etc-termcap ---
> install -l rs /tmp/ian//usr/share/misc/termcap /tmp/ian/etc/termcap
> ...
> revolution > file /tmp/ian/etc/termcap
> /tmp/ian/etc/termcap: symbolic link to ../usr/share/misc/termcap
>
>
> I haven't thought hard about whether adding DESTDIR like that would
> always fix the problem the right way.
DESTDIR != “” is the key point to triggering the bug that was causing the failures I noted in my other email (it has nothing to do with arm specifically). Rod’s code will only work for DESTDIR == “”.
Thanks,
-Ngie
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - https://gpgtools.org
iQIcBAEBCgAGBQJYxLsaAAoJEPWDqSZpMIYVNq4P/15F2TXTjynMO/EZAx2NGUDi
1ARd6dynMGxR+5uuiU910Rj010SyA6lodRAanZ4wLDNiXsTHbhf5smWGuIie/8yV
rUss5AzUDS9dCHvCis3eOOm9F8uR48q712VBIvCiq9lhZhS2uzfSvsmQFsdVnTff
VRwkGs/UrQ11ur30nePHqZLY+VThjHl03VvoNcnjrILbhi2EHSr9ArDPjSEx4Z0R
i4rsh8nm8ckRWmtrCwCfVfV9tQCp3hK1GTEYXxXq1FdLmtgiTO/2kWF7Nutk4ZH1
HnvI/p8c4ty1gheo86Duu46UKH/KHn6L+qRahl1xdvoFAbWqrjEYUEABB/jKucqo
+mBQT0VAhn6fDDs28Atm4ZtCJli83vsBI/1pD2BxuZTVwjXkc3MdALK+oel1cpsB
WZcvTaNnbEcx5/trD2tDHK1fMZG2N+8pFTuLc0CeG/BFKcVIDnxKgkMukW4hEs0C
JFdqqipAb3JiypzfYJXa+LOOuRzqwJZAYPxdiJvoCQ5R1VBywuTLwV8DcrA8R3nK
eD5w3GfKaXCff8+DBQDaGOYPqWEkQYIU/qZ1JKdUHivty7WX/UDasfxt8qlIJeA6
RriNeOizPPSNI+UnlnzKpf2IMZ/b0v3TJ+BPFyMhpovpnBpYw0TVYXT2Mi37MMo+
YOyUwG7ZD1SUAE5O9Aen
=Rh+E
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0EAE6C58-4573-4A71-97C8-0D672C814945>