Date: Fri, 11 Jan 2008 05:30:28 +1100 From: Peter Jeremy <peterjeremy@optushome.com.au> To: Robert Watson <rwatson@freebsd.org> Cc: src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org, obrien@freebsd.org, Max Laier <max@love2party.net>, Sam Leffler <sam@errno.com> Subject: Re: cvs commit: src/sys/netinet6 frag6.c icmp6.c in6.c in6_ifattach.c in6_pcb.c in6_proto.c in6_rmx.c in6_src.c ip6_input.c ip6_mroute.c ip6_output.c mld6.c nd6.c nd6_nbr.c nd6_rtr.c raw_ip6.c udp6_usrreq.c Message-ID: <20080110183028.GT4442@server.vk2pj.dyndns.org> In-Reply-To: <20080110085803.H66908@fledge.watson.org> References: <200801081908.m08J8wIs094059@repoman.freebsd.org> <200801082039.18671.max@love2party.net> <e7db6d980801082231p409d86bp34127fa153b56d7a@mail.gmail.com> <20080109170850.GA27993@dragon.NUXI.org> <4785058B.1050507@errno.com> <20080109201424.GA4969@server.vk2pj.dyndns.org> <478531AC.5030303@errno.com> <20080110085803.H66908@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--dc+cDN39EJAMEtIO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 10, 2008 at 08:59:59AM +0000, Robert Watson wrote: >In the past, we've had several subtle bugs crop up as a result of changing= =20 >to ANSI C function prototypes, which no longer automatically promote=20 >arguments to int from shorter types I hadn't considered that but it _is_ the sort of thing that comparing object files would detect - if you make a supposedly stylistic change and the generated code changes then it's time to take a much more careful look into what you are doing. > (I think it's that way around). That would be correct - I know Sun Studio 11 (at least) warns about the situation where mixing ANSI and K&R prototypes/definitions causes type mismatches due to implicit promotion. I thought gcc did as well. --=20 Peter Jeremy Please excuse any delays as the result of my ISP's inability to implement an MTA that is either RFC2821-compliant or matches their claimed behaviour. --dc+cDN39EJAMEtIO Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFHhmRE/opHv/APuIcRAiJCAKCKPAkSxqMlOMiISNvlshULHDK5QACgg9sv tJw5c3d6Y3BWhwqYngZFWPw= =H+UQ -----END PGP SIGNATURE----- --dc+cDN39EJAMEtIO--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080110183028.GT4442>