Date: Mon, 08 Nov 2004 13:58:57 -0800 From: Nate Lawson <nate@root.org> To: Anish Mistry <mistry.7@osu.edu> Cc: freebsd-acpi@freebsd.org Subject: Re: FJEX Fujitsu Function Buttons Message-ID: <418FEC21.2020603@root.org> In-Reply-To: <200411081654.48042.mistry.7@osu.edu> References: <200408021725.02891.mistry.7@osu.edu> <200408021729.31984.mistry.7@osu.edu> <411161C7.3040603@root.org> <200411081654.48042.mistry.7@osu.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
Anish Mistry wrote: > On Wednesday 04 August 2004 06:23 pm, Nate Lawson wrote: > >>Anish Mistry wrote: >> >>>On Monday 02 August 2004 05:24 pm, Anish Mistry wrote: >>> >>>>I've cleaned up the acpi_fuji module. Please comment on what needs to >>>>be changed for it to be committed. Thanks. >>>> >>>>http://am-productions.biz/docs/acpi_fjex.tgz >>> >>>Wow, I'm a moron. Correct link: >>>http://am-productions.biz/docs/acpi_fuji.tgz >> >>Thanks for the update. We'll definitely review it, make comments, etc. >> However, no new drivers should be imported before 5.3-RELEASE. We >>need to spend time cleaning up existing drivers and bugfixing. > > Now that 5.3 is out the door what do I need to do to get this committed? Thanks for pinging me. I'd like to see it match style(9) (i.e. 8 space tabs.) All new code in acpi has done this. Also, it could use locking (serialization would be fine since this code isn't in any fast path). Also, I assume you have a script for driving it? -- Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?418FEC21.2020603>