Date: Thu, 7 Apr 2005 07:51:13 -0500 From: Jacques Vidrine <nectar@FreeBSD.org> To: <current@freebsd.org> Cc: sparc64@freebsd.org Subject: Re: [current tinderbox] failure on sparc64/sparc64 Message-ID: <ba995abc5e1d1deb9f39f1a2c6ee3aed@FreeBSD.org> In-Reply-To: <20050406153614.BA6877306E@freebsd-current.sentex.ca> References: <20050406153614.BA6877306E@freebsd-current.sentex.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail-6--720396101
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
charset=US-ASCII;
format=flowed
On Apr 6, 2005, at 10:36 AM, FreeBSD Tinderbox wrote:
> /tinderbox/CURRENT/sparc64/sparc64/src/libexec/rexecd/rexecd.c: In
> function `doit':
> /tinderbox/CURRENT/sparc64/sparc64/src/libexec/rexecd/rexecd.c:204:
> warning: cast increases required alignment of target type
> *** Error code 1
Gah, I'm cursed.
139 char user[16], pass[16];
204 !pam_ok(pam_get_item(pamh, PAM_USER, (const void
**)&user)) ||
Before I churn the code more :-/, does someone have a much better
suggestion than the attached?
Cheers,
--
Jacques A Vidrine / NTT/Verio
nectar@celabo.org / jvidrine@verio.net / nectar@freebsd.org
--Apple-Mail-6--720396101
Content-Transfer-Encoding: 7bit
Content-Type: application/octet-stream;
x-unix-mode=0644;
name="rexecd.patch"
Content-Disposition: attachment;
filename=rexecd.patch
? rexecd
? rexecd.8.gz
Index: rexecd.c
===================================================================
RCS file: /home/ncvs/src/libexec/rexecd/rexecd.c,v
retrieving revision 1.39
diff -c -u -r1.39 rexecd.c
--- rexecd.c 5 Apr 2005 18:25:27 -0000 1.39
+++ rexecd.c 7 Apr 2005 12:45:55 -0000
@@ -136,9 +136,9 @@
{
char *cmdbuf, *cp;
int maxcmdlen;
- char user[16], pass[16];
+ char userbuf[16], pass[16];
struct passwd *pwd, pwd_storage;
- char *pwdbuf;
+ char *pwdbuf, *user;
size_t pwdbuflen;
int fd, r, sd;
u_short port;
@@ -189,6 +189,7 @@
if (connect(sd, fromp, fromp->sa_len) < 0)
exit(1);
}
+ user = userbuf;
getstr(user, sizeof(user), "username");
getstr(pass, sizeof(pass), "password");
getstr(cmdbuf, maxcmdlen, "command");
--Apple-Mail-6--720396101
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
charset=US-ASCII;
format=flowed
--Apple-Mail-6--720396101--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ba995abc5e1d1deb9f39f1a2c6ee3aed>