Date: Wed, 23 Apr 2008 21:06:59 +0200 From: Jeremie Le Hen <jeremie@le-hen.org> To: Eygene Ryabinkin <rea-fbsd@codelabs.ru> Cc: freebsd-current@freebsd.org Subject: Re: [RFC] Automated generation of /etc/resolv.conf from the rc.d script Message-ID: <20080423190659.GT92168@obiwan.tataz.chchile.org> In-Reply-To: <RlIwVx1VnA2Q57cUUvUPn30sch4@BBB3ZKOzjjN0cxeKaWhgH87x7VY> References: <dEZnki0Fi32EvMrDEnqcgDeNQSc@Bbw9J2Iynx0QjNoWuQ4YSitYS3A> <72389.1197629858@critter.freebsd.dk> <MIKiw94aov2StL37zxYPU2cwfyE@NKorCT8tqQREs5VbYbldlgOz9%2B8> <RlIwVx1VnA2Q57cUUvUPn30sch4@BBB3ZKOzjjN0cxeKaWhgH87x7VY>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Eygene, On Mon, Apr 14, 2008 at 07:44:13PM +0400, Eygene Ryabinkin wrote: > [...] > Testing and feedback are more than welcome. I didn't test your patch but I have a have a few comments about it: In install_new_file(), I don't think you should test for $CMP being an executable file... It is in the base system and the rule of thumb in other rc.d scripts is to use those directly. I'm not sure you should chown/chmod the forwarders file. People may have custom setup that you should not interfere with without a good reason. Also, I would rather let add_new_bind_forwarders() build the "empty" forwarders file, it would make more sense IMHO. You could then put a single call to add_new_bind_forwarders() at the end of the script under a $resolv_build_named_forwarders condition. It makes more sense indeed to test this outside of the function, my personal feeling being that it makes the reading less puzzling. Anyway, thank you very much for your work. I think many people will enjoy it once it will hit the source tree. Best regards, -- Jeremie Le Hen < jeremie at le-hen dot org >< ttz at chchile dot org >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080423190659.GT92168>