Date: Mon, 22 Jan 2018 12:43:10 -0600 From: Kyle Evans <kevans@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328263 - head/lib/libregex Message-ID: <CACNAnaFGqyN388dgVGbSjatxEC_sED=xoCNAsDh1yUpmJgshmg@mail.gmail.com> In-Reply-To: <201801221840.w0MIeJls082586@repo.freebsd.org> References: <201801221840.w0MIeJls082586@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jan 22, 2018 at 12:40 PM, Kyle Evans <kevans@freebsd.org> wrote: > Author: kevans > Date: Mon Jan 22 18:40:19 2018 > New Revision: 328263 > URL: https://svnweb.freebsd.org/changeset/base/328263 > > Log: > libregex: Add a symbol map > > kib points out that trying to re-use symbol versioning from libc is dirty > and wrong. The implementation in libregex is incompatible by design with the > implementation in libc. Using the symbol versions from libc can and likely > will cause confusions for linkers and bring unexpected behavior for > consumers that unwillingly (transitively) link against libregex. > > Reported by: kib > Another thing I forgot to note here: libregex symbol versioning was actually not happening prior to this commit due to failure to define VERSION_DEF. This has also been corrected in this commit.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaFGqyN388dgVGbSjatxEC_sED=xoCNAsDh1yUpmJgshmg>