Date: Mon, 16 Feb 1998 07:54:21 +1030 From: Greg Lehey <grog@lemis.com> To: "Jordan K. Hubbard" <jkh@time.cdrom.com> Cc: Chris Csanady <ccsanady@friley585.res.iastate.edu>, freebsd-current@FreeBSD.ORG Subject: Re: CCD missing spl() call.. Message-ID: <19980216075421.52560@freebie.lemis.com> In-Reply-To: <20539.887533728@time.cdrom.com>; from Jordan K. Hubbard on Sun, Feb 15, 1998 at 01:08:48AM -0800 References: <19980215191452.63038@freebie.lemis.com> <20539.887533728@time.cdrom.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 15 February 1998 at 1:08:48 -0800, Jordan K. Hubbard wrote:
>> (omitting some #ifdef DEBUG stuff)
>>
>> s = splbio();
>>
>> if (cbp->cb_buf.b_flags & B_ERROR) {
>
> Erm.. You're in ccdiodone(),
Yup.
> a completely different function from the one I (and the submitted
> patch) was referring to. :-)
I don't know what function you were referring to, since you don't
mention the name. All I have to go on is the original patch:
***************
*** 973,978 ****
--- 973,979 ----
register int unit = cbp->cb_unit;
int count, s;
+ s = splbio();
#ifdef DEBUG
if (ccddebug & CCDB_FOLLOW)
printf("ccdiodone(%x)\n", cbp);
This patch definitely applies to ccdiodone. Look at the text in the
last line of the patch. What do you have at line 976 of your copy of
/usr/src/sys/dev/ccd/ccd.c?
Greg
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19980216075421.52560>