Date: Fri, 8 Jan 2016 09:04:48 -0800 From: "alex.burlyga.ietf alex.burlyga.ietf" <alex.burlyga.ietf@gmail.com> To: Ravi Pokala <rpokala@mac.com> Cc: freebsd-net@freebsd.org Subject: Re: [Differential] [Request, 6 lines] D4825: tcp/lro: Add network driver configurable LRO entry depth Message-ID: <CA%2BJhTNSGN0gDin4O9QVMApQ546Uj31fjQvHL2OsjMqEESzs1gg@mail.gmail.com> In-Reply-To: <CF7AE0AF-5471-4454-8EFF-63E31957A420@panasas.com> References: <CF7AE0AF-5471-4454-8EFF-63E31957A420@panasas.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Perhaps Sephe planing to use it as a sysctl? Alex. On Jan 8, 2016 07:59, "Ravi Pokala" <rpokala@mac.com> wrote: > -----Original Message----- > > > >Date: Fri, 8 Jan 2016 02:29:22 +0000 > >From: "sepherosa_gmail.com (Sepherosa Ziehau)" > > <phabric-noreply@FreeBSD.org> > >To: freebsd-net@freebsd.org > >Subject: [Differential] [Request, 6 lines] D4825: tcp/lro: Add network > > driver configurable LRO entry depth > >Message-ID: > > <differential-rev-PHID-DREV-ou2jiti5cx3pzqhm5pb2-req@FreeBSD.org> > >Content-Type: text/plain; charset="utf-8" > > > >sepherosa_gmail.com created this revision. > >sepherosa_gmail.com added reviewers: network, adrian, delphij, > decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com, glebius. > >sepherosa_gmail.com added a subscriber: freebsd-net-list. > >Herald added a reviewer: transport. > > > >REVISION SUMMARY > > When there is only tiny amount of TCP connections and the host is slow, > e.g. in VM, holding too much TCP segments in an LRO entry will cause RX > performance degradation. We now allow network drivers to configure how > deep one LRO entry should be. > > Forgive me if I'm missing something obvious, but this patch doesn't > actually change anything - rather than hard-coding 65535, you're using > lc->lro_hiwat... which is hard-coded to 65535. > > Right? > > -Ravi (rpokala@) > > _______________________________________________ > freebsd-net@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2BJhTNSGN0gDin4O9QVMApQ546Uj31fjQvHL2OsjMqEESzs1gg>