Date: Sun, 5 Jul 2015 13:50:54 -0700 From: Garrett Cooper <yaneurabeya@gmail.com> To: Ian Lepore <ian@FreeBSD.org> Cc: John-Mark Gurney <jmg@funkthat.com>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r285160 - head/sys/conf Message-ID: <B568D1BB-3743-494A-9C72-EA42A9FF6E70@gmail.com> In-Reply-To: <495E11C2-BB42-4687-8551-604C1F14D37E@gmail.com> References: <201507051415.t65EFxWd044357@repo.freebsd.org> <20150705194954.GA8523@funkthat.com> <1436126730.1191.4.camel@freebsd.org> <495E11C2-BB42-4687-8551-604C1F14D37E@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Jul 5, 2015, at 13:49, Garrett Cooper <yaneurabeya@gmail.com> wrote: > On Jul 5, 2015, at 13:05, Ian Lepore <ian@FreeBSD.org> wrote: > >> On Sun, 2015-07-05 at 12:49 -0700, John-Mark Gurney wrote: >>> Ian Lepore wrote this message on Sun, Jul 05, 2015 at 14:15 +0000: >>>> Author: ian >>>> Date: Sun Jul 5 14:15:58 2015 >>>> New Revision: 285160 >>>> URL: https://svnweb.freebsd.org/changeset/base/285160 >>>> >>>> Log: >>>> Ensure all the required files get built when you include the IPSEC option. >>> >>> Umm.. This looks more like that IPSEC should require that the crypto >>> device be specified instead of fixing it this way... >> >> I considered that, but rejected it given the presence of crypto | ipsec >> on some of the files already, but not a sufficiency of them to actually >> build sucessfully. Heavily my thinking that was a personal belief that >> if you say "option foo" it should just work without you needing to know >> other (likely not well documented) prerequisite options also need to be >> set. > > Or… just create a manpage that says “options IPSEC” requires “device crypto”? Oh wait — there already is one and it states exactly that... https://www.freebsd.org/cgi/man.cgi?query=ipsec&apropos=0&sektion=0&manpath=FreeBSD+10.1-RELEASE&arch=default&format=html . Maybe just add some comments in the KERNCONFs to note that “options IPSEC” requires “device crypto”? [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJVmZiuAAoJEMZr5QU6S73e4GwH/j4Z3r5iNFhRzwBrEkURm6yN SNtF3UgDnNEYRB/VGJDDVNBkrglqu+aW2qgHAxqAJgbANDuOAoQW83bgmY1lOSwm JW2k/MHniKJ6TlQaycVJbk1eBawKlbAvAJsUS3hCoKS/gXS7PEwPuoDPc6fEvcYj IXJcf80aTwp4U8qRRzxqycIDg0L2gE9f5qlBjhCMw3UyGdqKDeEoTCheUA8ezSaO STRiwSWlH8mGP5aJYt5OyrVuvr0ns4r3CnmRkoKuWUOoPQaQ4or51DACGE+bP4uX scdtgp2/S+64rhBlIeIKGd0HW6rW5RxrTVEf7z9XSmCklNdXumSji+jbFvwwr3A= =+D+/ -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B568D1BB-3743-494A-9C72-EA42A9FF6E70>