Date: Tue, 3 Mar 2026 09:59:59 -0800 From: "Enji Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: "George V. Neville-Neil" <gnn@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: bc9229035c5f - main - Allow programs run under this program to have arguments. Message-ID: <C10A23CC-131B-4F9D-9B8A-28E9F470DF1F@gmail.com> In-Reply-To: <69a7162e.3e996.108a155f@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] > On Mar 3, 2026, at 9:11 AM, George V. Neville-Neil <gnn@FreeBSD.org> wrote: > > The branch main has been updated by gnn: > > URL: https://cgit.FreeBSD.org/src/commit/?id=bc9229035c5f46674cf06b48d66e9f039b3a9875 > > commit bc9229035c5f46674cf06b48d66e9f039b3a9875 > Author: George V. Neville-Neil <gnn@FreeBSD.org> > AuthorDate: 2026-03-03 17:10:26 +0000 > Commit: George V. Neville-Neil <gnn@FreeBSD.org> > CommitDate: 2026-03-03 17:10:42 +0000 > > Allow programs run under this program to have arguments. > --- > tools/test/hwpmc/pmctest.py | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/tools/test/hwpmc/pmctest.py b/tools/test/hwpmc/pmctest.py > index ba20306f1d68..1c113c256e32 100755 > --- a/tools/test/hwpmc/pmctest.py > +++ b/tools/test/hwpmc/pmctest.py > @@ -27,6 +27,7 @@ import argparse > import tempfile > from pathlib import Path > import os > +import shlex > > def gather_counters(): > """Run program and return output as array of lines.""" > @@ -58,7 +59,9 @@ def main(): > print("Choose one of --count OR --sample.") > sys.exit() > > - program = Path(args.program).name > + # Split program and arguments properly > + program_parts = shlex.split(args.program) > + program = Path(program_parts[0]).name > > if args.count == True: > tmpdir = tempfile.mkdtemp(prefix=program + "-", suffix="-counting-pmc") > @@ -73,8 +76,7 @@ def main(): > continue > if args.count == True: > with open(tmpdir + "/" + program + "-" + counter + ".txt", 'w') as file: > - p = subprocess.Popen(["pmcstat", > - "-p", counter, args.program], > + p = subprocess.Popen(["pmcstat", "-p", counter] + program_parts, > text=True, stderr=file, stdout=file) Hi George, The idiom that ruff recommends here is to use the unpacking operator. For example, instead of doing: a = [] b = [] + a They recommend using: a = [] b = [*a] More about the rationale for this suggestion is discussed here: https://docs.astral.sh/ruff/rules/collection-literal-concatenation/ . -Enji [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmmnIZ8ACgkQGpE5DjPs NJjbXw//YybrvdsnUnxQDX7ec9+agmAmf/DtT7Zbao2pbYeQ3Z+DbfHUENlcrbz7 SXNxfpHlheq8UxFWyhy8h5fiioUOHkOBct9WI+u3xJmxq/zjl68GgIeDWnQvKdV9 mo9hFWzejW4nYk8ZblPvp9aTOpNq8NXrTzEOvj976qNHsAC/uHNjUiZi0IZM07+j aNJ98PERwrDF1QYw47nqRUuwaUfoSeydLfDYHue6XiI7DkksZzagQPYYHLqesSbo GAZuOqFzRR4VtKGAnrAbf6jqDaF4j7mgWOLp4+oRu3e0VUvngl9T5AItOre50Pgz jHFEKKOuMbhCm0Nnm6hqsfNCF9qc0b/N50EOgva4e/e82OYDiHB+vm4wqUXxcXJB 72U7b9qs4t2BejgMUbm3HM2xekK0f25Ku1WYGG1XzZGQkGIDCYuBH+WSkXW7XFDI Cy6wMd5cUT6TG/CDtYDXE2mG6V/I+39M35R4UVfySZFq63qpzUsXAmGxU5Yz3Bx2 TJnSGFYGv49NVfAjT6BmzSTtb6gFRfAlcfJk7rzqErgIkrYDW2y/q+LjBo2PTjBR KGFGWfZGmygfdmRkF34ZsVtyVPtuYEUEF8QqRVapS3kpxTDlMcQzsKP8PLRTzZLu qvf+Rro/IxTnNGSFYu167b1IwsUjsgZj04+mi8g3LTULgSuXmig= =xZhW -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C10A23CC-131B-4F9D-9B8A-28E9F470DF1F>