Date: Tue, 05 Jan 2010 14:02:50 +0800 From: David Xu <davidxu@freebsd.org> To: Alexander Kabaev <kabaev@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r201547 - head/lib/libc/gen Message-ID: <4B42D60A.1090901@freebsd.org> In-Reply-To: <20100105005042.7fd9db85@kan.dnsalias.net> References: <201001050339.o053dV1j075171@svn.freebsd.org> <20100104233946.6d8bfa37@kan.dnsalias.net> <4B42D07A.5000803@freebsd.org> <20100105005042.7fd9db85@kan.dnsalias.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Alexander Kabaev wrote: > On Tue, 05 Jan 2010 13:39:06 +0800 > David Xu <davidxu@freebsd.org> wrote: > >> Alexander Kabaev wrote: >>> Hi, >>> >>> some quick questions: >>> >>> FB10_COMPAT_PRIVATE is not used anywhere, why did it get committed? >>> That aside, use of SYM_DEFAULT is pretty much always wrong. >>> >> Yes, this needs to be cleaned. >> >>> Also, does libthr really need to export sem_ symbols in 1.2 >>> namespace? I do not think so, but there might be reasons I am >>> missing, could you shed some light here? >>> >> If libthr.so does not have 1.2 semaphore, a program linked against >> libthr may use 1.0 version at linking time, doesn't this cause >> trouble? anyway, I am not symbol versioning expert, welcome to fix it. >> > > No, that won't happen. Compat (single '@') symbols are only resolvable > at runtime, bit at link time, so ld won't see any sem_ symbols in libthr > and by necessity will pick ones from libc. > > My previous test got opposite result, it sticked with libthr, but this time I tested it again, you are right, it uses version 1.2 from libc. I will remove extra stubs from libthr.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B42D60A.1090901>