Date: Mon, 25 Jan 2021 19:32:20 -0800 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Cy Schubert <cy@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 83edbc3cb54f - main - ipfilter: Retire pre-standard C support. Message-ID: <202101260332.10Q3WKuW003844@slippy.cwsent.com> In-Reply-To: <YA911GqWfTxylFBk@rincewind.trouble.is> References: <202101252247.10PMlBd2027258@gitrepo.freebsd.org> <YA911GqWfTxylFBk@rincewind.trouble.is>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <YA911GqWfTxylFBk@rincewind.trouble.is>, Philip Paeps writes: > On 2021-01-25 22:47:11 (+0000), Cy Schubert wrote: > > ipfilter: Retire pre-standard C support. > > > > All C compilers in 2021 support standard C and architectures that did > > not were retired long ago. Simplify by removing now redundant > > pre-standard C code. > > [...] > > > > #ifndef __P > >-# ifdef __STDC__ > > # define __P(x) x > >-# else > >-# define __P(x) () > >-# endif > >-#endif > > You could simplify even further by getting rid of the __P() convention > altogether. All our compilers support prototypes in 2021. :) Yes, it's in my queue. ANSI function definitions is in another branch. The last cleanup being style(9). -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: https://FreeBSD.org NTP: <cy@nwtime.org> Web: https://nwtime.org The need of the many outweighs the greed of the few.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202101260332.10Q3WKuW003844>