Date: Mon, 23 Jul 2018 09:41:18 -0700 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Alan Somers <asomers@freebsd.org> Cc: Ian Lepore <ian@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: RE: svn commit: r336619 - head/lib/libc/gen Message-ID: <20180723164115.40C7E948@spqr.komquats.com>
next in thread | raw e-mail | index | archive | help
I'm sure. Rolling this libc commit back addressed the ssh segfaults on all = my systems. --- Sent using a tiny phone keyboard. Apologies for any typos and autocorrect. Also, this old phone only supports top post. Apologies. Cy Schubert <Cy.Schubert@cschubert.com> or <cy@freebsd.org> The need of the many outweighs the greed of the few. --- -----Original Message----- From: Alan Somers Sent: 23/07/2018 07:48 To: Cy Schubert Cc: Ian Lepore; src-committers; svn-src-all@freebsd.org; svn-src-head@freeb= sd.org Subject: Re: svn commit: r336619 - head/lib/libc/gen On Sun, Jul 22, 2018 at 11:13 PM, Cy Schubert <Cy.Schubert@cschubert.com> w= rote: In message <201807222234.w6MMYKpn030237@repo.freebsd.org>, Ian Lepore=20 writes: =20 > Author: ian > Date: Sun Jul 22 22:34:20 2018 > New Revision: 336619 > URL: https://svnweb.freebsd.org/changeset/base/336619 > > Log: > Set the pw_class field to NULL when scanning the non-master passwd fil= e. > This avoids a null pointer deref in pw_dup(), which assumes that all > pointers are either NULL or valid. > > Modified: > head/lib/libc/gen/pw_scan.c > =20 Hi Ian, =20 This causes ssh a bit of gas. =20 Are you sure, Cy? Judging by the Jenkins output, I think it was the next r= evision to pw (336625) that broke everything. https://ci.freebsd.org/job/F= reeBSD-head-amd64-test/8320/ . -Alan =
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180723164115.40C7E948>