Date: Fri, 28 Nov 2014 10:54:25 -0800 From: Adrian Chadd <adrian@freebsd.org> To: Steve Kargl <sgk@troutmask.apl.washington.edu> Cc: freebsd-current <freebsd-current@freebsd.org> Subject: Re: Possible bug in softfloat Message-ID: <CAJ-Vmok8xHjK0Vjh5JRKbvSUv=3Rs=jhgCtboYbXPVc_yHii1A@mail.gmail.com> In-Reply-To: <20141128183416.GA71749@troutmask.apl.washington.edu> References: <20141128183416.GA71749@troutmask.apl.washington.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On 28 November 2014 at 10:34, Steve Kargl
<sgk@troutmask.apl.washington.edu> wrote:
> In a thread on comp.lang.c, it was pointed out that softfloat
> has a bug and in checking src/lib/libc/softfloat I confimed
> the issue is present in FreeBSD. What I hae not confirmed
> is whether or not it is possible to hit this bug. In fact,
> it may only hit arm and mips. Anyway, here's the patch
So we should just commit this?
-a
>
>
> Index: softfloat/bits64/softfloat-macros
> ===================================================================
> --- softfloat/bits64/softfloat-macros (revision 275211)
> +++ softfloat/bits64/softfloat-macros (working copy)
> @@ -157,7 +157,7 @@
> z0 = a0>>count;
> }
> else {
> - z1 = ( count < 64 ) ? ( a0>>( count & 63 ) ) : 0;
> + z1 = ( count < 128 ) ? ( a0>>( count & 63 ) ) : 0;
> z0 = 0;
> }
> *z1Ptr = z1;
>
> --
> Steve
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmok8xHjK0Vjh5JRKbvSUv=3Rs=jhgCtboYbXPVc_yHii1A>