Date: Tue, 05 Sep 2006 23:31:34 +0200 From: Andre Oppermann <andre@freebsd.org> To: Jack Vogel <jfvogel@gmail.com> Cc: freebsd-net <freebsd-net@freebsd.org>, freebsd-current <freebsd-current@freebsd.org>, Prafulla Deuskar <pdeuskar@freebsd.org> Subject: Re: RFC: TSO patch for current Message-ID: <44FDECB6.2040304@freebsd.org> In-Reply-To: <2a41acea0609051410i7d968b88ocf240514ff410452@mail.gmail.com> References: <2a41acea0609011551v40338539u4eef48d091dd12ab@mail.gmail.com> <44F9384C.9070902@freebsd.org> <2a41acea0609021741y481a04c0r42902166eaba78d7@mail.gmail.com> <20060905162542.GA63869@hub.freebsd.org> <44FDAF08.20407@freebsd.org> <20060905182313.GA85389@hub.freebsd.org> <44FDD65C.6070109@freebsd.org> <2a41acea0609051410i7d968b88ocf240514ff410452@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Jack Vogel wrote: > On 9/5/06, Andre Oppermann <andre@freebsd.org> wrote: >> Prafulla Deuskar wrote: >> > Your patch looks good and is the way to go. >> > >> > So after Jack confirms that your patch works with the em driver >> > would you commit to to -current? >> >> Absolutely. :-) >> >> > The driver related changes can follow.. >> > >> > Later we also need to fix ifconfig so that user can enable/disable >> TSO on the interface. >> >> I'll do that together with the TSO code. > > OK, I've built and done some touch testing of this. I like it, the > driver has > some counters of the number of TSO bursts it does, and I think I see more > per netperf test with your patch than mine. > > Hard to do real performance testing with all that WITNESS stuff in, but > I will be making a 6.1 version of your patch to test with since I have my > driver running on that anyway. You can disable WITNESS and INVARIANTS pretty easily in -current and get the full performance with it. > If you do the ifconfig changes there will need to be a small amount of > code added to em_ioctl() but it should be trivial. > > You want me to reissue a driver patch with changes for your code? Yes, please do so. I've got a dual-em card which I can test with myself. -- Andre
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?44FDECB6.2040304>