Date: Tue, 12 Dec 2017 12:22:51 -0700 From: Warner Losh <imp@bsdimp.com> To: Mateusz Guzik <mjguzik@gmail.com> Cc: Antoine Brodin <antoine@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, src-committers <src-committers@freebsd.org> Subject: Re: svn commit: r326792 - head/stand/uboot/common Message-ID: <CANCZdfoFDcY%2BT8y9md4M=i35fQ2mVsUsgX6hgjFEFAoOjTo8cQ@mail.gmail.com> In-Reply-To: <CAGudoHG150WR1VuGnKniBckLOBK8Y0RaroqR3-6e0sB8_hjB%2Bw@mail.gmail.com> References: <201712120946.vBC9krNL075725@repo.freebsd.org> <CANCZdfrja83nEyycA1NOU9LJAO59_PHbbnPRhiuV-x3BWTv2=g@mail.gmail.com> <CANCZdfpYWwKAHxWYjHQY9C2CLV5FYeEW8yr0VLZz4F-XP6aMMw@mail.gmail.com> <CAGudoHG150WR1VuGnKniBckLOBK8Y0RaroqR3-6e0sB8_hjB%2Bw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 12, 2017 at 12:13 PM, Mateusz Guzik <mjguzik@gmail.com> wrote: > How about you both close one PR as a punishment and we pretend this did > not happen. > I'll fix 6 CIDs as punishment. Warner > The thing to do was to reply to the offending commit or contact the > committer > on irc. Only in case of no timely response fixing on your own is the right > thing > to do. > > > On Tue, Dec 12, 2017 at 8:03 PM, Warner Losh <imp@bsdimp.com> wrote: > >> The email I wrote here also sucks. It was unduly harsh. While the commit >> message should have been better, I was too harsh in trying to express this >> and giving a better example. >> >> Warner >> >> On Tue, Dec 12, 2017 at 5:49 AM, Warner Losh <imp@bsdimp.com> wrote: >> >> > This commit message sucks. Please use a more descriptive one in the >> future >> > like "catch up to change rXXXXX that remove the argument from >> interact." If >> > you want to be snarky, add 'pounty hat to imp' to it. Thats infornative. >> > Your message is utterly useless. It doesn't even say what arch is >> broken. >> > >> > Warner >> > >> > Warner >> > >> > On Dec 12, 2017 1:47 AM, "Antoine Brodin" <antoine@freebsd.org> wrote: >> > >> >> Author: antoine >> >> Date: Tue Dec 12 09:46:53 2017 >> >> New Revision: 326792 >> >> URL: https://svnweb.freebsd.org/changeset/base/326792 >> >> >> >> Log: >> >> Attempt to unbreak buildworld >> >> >> >> Modified: >> >> head/stand/uboot/common/main.c >> >> >> >> Modified: head/stand/uboot/common/main.c >> >> ============================================================ >> >> ================== >> >> --- head/stand/uboot/common/main.c Tue Dec 12 06:56:21 2017 >> >> (r326791) >> >> +++ head/stand/uboot/common/main.c Tue Dec 12 09:46:53 2017 >> >> (r326792) >> >> @@ -500,7 +500,7 @@ main(int argc, char **argv) >> >> archsw.arch_readin = uboot_readin; >> >> archsw.arch_autoload = uboot_autoload; >> >> >> >> - interact(NULL); /* doesn't return */ >> >> + interact(); /* doesn't return */ >> >> >> >> return (0); >> >> } >> >> >> >> >> _______________________________________________ >> svn-src-all@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/svn-src-all >> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" >> > > > > -- > Mateusz Guzik <mjguzik gmail.com> >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoFDcY%2BT8y9md4M=i35fQ2mVsUsgX6hgjFEFAoOjTo8cQ>