Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 13 May 2002 07:00:43 -0400
From:      Dan Eischen <eischen@vigrid.com>
To:        Alfred Perlstein <alfred@FreeBSD.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/lib/libc_r/uthread pthread_private.h  uthread_attr_setguardsize.cuthread_init.c uthread_stack.c
Message-ID:  <3CDF9CDB.BF0E65F5@vigrid.com>
References:  <200205130758.g4D7wFo67279@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Alfred Perlstein wrote:
> 
> alfred      2002/05/13 00:58:15 PDT
> 
>   Modified files:
>     lib/libc_r/uthread   pthread_private.h
>                          uthread_attr_setguardsize.c
>                          uthread_init.c uthread_stack.c
>   Log:
>   Don't use PAGE_SIZE in userland, instead use getpagesize(), this is to
>   allow running on other arches when the instructions are supported but
>   the page size granularity is not.

This adds namespace pollution to libc_r.  Please fix and precede externals
with underscores.  You should be able to do 'nm libc_r.so.5 | grep " T "'
and not see anything that isn't preceded with underscores.

-- 
Dan Eischen

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3CDF9CDB.BF0E65F5>