Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 29 Aug 2020 10:56:12 +0200
From:      Hans Petter Selasky <hps@selasky.org>
To:        Warner Losh <imp@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r364944 - head/sys/kern
Message-ID:  <25be5af1-76a9-78a1-4e4f-2777b0e7f350@selasky.org>
In-Reply-To: <202008290429.07T4TrbH007764@repo.freebsd.org>
References:  <202008290429.07T4TrbH007764@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2020-08-29 06:29, Warner Losh wrote:
> +#define DEVCTL_BUFFER (1024 - sizeof(void *))
>   struct dev_event_info {
> -	char *dei_data;
>   	STAILQ_ENTRY(dev_event_info) dei_link;
> +	char dei_data[DEVCTL_BUFFER];
>   };

Maybe add:

CTASSERT(sizeof(struct dev_event_info) == 1024);

Not sure if STAILQ's can have some debug fields in them.

--HPS



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?25be5af1-76a9-78a1-4e4f-2777b0e7f350>