Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 13 Jan 2013 08:58:50 -0800 (PST)
From:      Dru Lavigne <dru.lavigne@att.net>
To:        freebsd-doc@freebsd.org
Subject:   Re: [patch] content changes to X11 chapter
Message-ID:  <1358096330.196.YahooMailClassic@web184906.mail.gq1.yahoo.com>
In-Reply-To: <50F2CC15.3070800@FreeBSD.org>

index | next in thread | previous in thread | raw e-mail



> >> On Fri, Jan 11, 2013 at 02:31:52PM -0800, Dru
> Lavigne wrote:
> >>> Attached is the svn diff for the X11 chapter.
> This
> >> represents a
> >>> complete content update of this chapter.
> >>> 
> >>> Igor is mostly happy. I think the remaining
> indent
> >> errors are false
> >>> warnings as they only occur when an inline tag
> is in
> >> the previous
> >>> <para>.
> >>> 
> >>> I did not verify the widescreen settings. I
> think the
> >> i810 section is
> >>> correct. The KDM section needs more content.
> Other than
> >> that, it is a
> >>> decent first pass at bringing this chapter into
> the
> >> 21st century.
> >>> 
> >> 
> >> Some thoughts:
> >> 
> >> - the whole diff will be difficult to read for a
> translator: 
> >> section moves, whitespace & content changes,
> etc. It will be
> >> important to commit in separate parts: for example:
> 1st section 
> >> moves/removals, 2nd addition & content changes
> and 3rd 
> >> whitespace/indentation changes;
> >> 
> >> - you removed the prerequisite of knowing how to
> use ports, I
> >> think it's important to know how to get a ports
> tree before using
> >> the ports;
> >> 
> >> - you removed the way to get a localized keyboard
> for people not
> >> using a desktop manager.  Well this
> configuration is not easy to
> >> guess for a newcomer.  Maybe it can be kept
> somewhere in the 
> >> chapter.
> >> 
> >> - What is # in Crtl+Alt+F#?
> > 
> > 
> > Please note that the whitespace changes were sent as a
> separate
> > patch ([patch] white space only fix for handbook x11
> chapter) on
> > the 10th. It is my understanding that the first patch
> will be
> > applied to the handbook repo while the second content
> patch will
> > most likely be applied to the print edition repo.


My bad, I didn't realize the white-space patch had already been committed. I will redo this and send the patches by Tuesday.

Cheers,

Dru


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1358096330.196.YahooMailClassic>