Date: Wed, 26 Sep 2012 09:56:03 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Ed Maste <emaste@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r240938 - head/sys/net Message-ID: <20120926075603.GK1391@garage.freebsd.pl> In-Reply-To: <20120926075442.GJ1391@garage.freebsd.pl> References: <201209252210.q8PMAEx5003950@svn.freebsd.org> <20120926075442.GJ1391@garage.freebsd.pl>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Wed, Sep 26, 2012 at 09:54:43AM +0200, Pawel Jakub Dawidek wrote:
> On Tue, Sep 25, 2012 at 10:10:14PM +0000, Ed Maste wrote:
> [...]
> > Note: if_tun had the same issue, addressed in SVN revisions r186391,
> > r186483 and r186497. The use of the condvar there appears to be
> > redundant with the functionality provided by destroy_dev.
> [...]
> > --- head/sys/net/if_tapvar.h Tue Sep 25 21:33:36 2012 (r240937)
> > +++ head/sys/net/if_tapvar.h Tue Sep 25 22:10:14 2012 (r240938)
> > @@ -64,6 +64,7 @@ struct tap_softc {
> > SLIST_ENTRY(tap_softc) tap_next; /* next device in chain */
> > struct cdev *tap_dev;
> > struct mtx tap_mtx; /* per-softc mutex */
> > + struct cv tap_cv; /* protect ref'd dev destroy */
> > };
>
> So maybe there is no need to add it?:)
I'm sooo late, sorry.
--
Pawel Jakub Dawidek http://www.wheelsystems.com
FreeBSD committer http://www.FreeBSD.org
Am I Evil? Yes, I Am! http://tupytaj.pl
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)
iEYEARECAAYFAlBitRIACgkQForvXbEpPzSo0wCdHWAdrwD3X47CuUqHYksdobMo
yVkAnRyXcdrPnSBLgiPownREMTOQtCxb
=jLtE
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120926075603.GK1391>