Date: Mon, 10 Apr 2006 18:57:15 GMT From: Warner Losh <imp@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 94940 for review Message-ID: <200604101857.k3AIvFF2035668@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=94940 Change 94940 by imp@imp_Speedy on 2006/04/10 18:56:56 Nits, but important ones that makes the download work. Affected files ... .. //depot/projects/arm/src/sys/boot/arm/kb920x/boot0/xmodem.c#4 edit Differences ... ==== //depot/projects/arm/src/sys/boot/arm/kb920x/boot0/xmodem.c#4 (text+ko) ==== @@ -55,7 +55,7 @@ goto err; if ((ch = getc(1)) == -1) goto err; - if (ch != ~blocknum & 0xff) + if (ch != (~blocknum & 0xff)) goto err; for (size = 0; size < PACKET_SIZE; ++size) { @@ -73,10 +73,10 @@ chk &= 0xFFFF; - if (((ch = getc(1)) == -1) || (ch & 0xff != ((chk >> 8) & 0xFF))) - goto err; - if (((ch = getc(1)) == -1) || (ch & 0xff != (chk & 0xFF))) - goto err; + if (((ch = getc(1)) == -1) || ((ch & 0xff) != ((chk >> 8) & 0xFF))) + goto err; + if (((ch = getc(1)) == -1) || ((ch & 0xff) != (chk & 0xFF))) + goto err; putc(ACK); return (1);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200604101857.k3AIvFF2035668>