Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 14 Jan 2003 10:32:36 +0100 (CET)
From:      Martin Blapp <mb@imp.ch>
To:        Thomas Moestl <tmoestl@gmx.net>
Cc:        current@freebsd.org, "" <net@freebsd.org>
Subject:   Re: PANIC in tcp_syncache.c sonewconn() line 562
Message-ID:  <20030114100620.W76016@levais.imp.ch>
In-Reply-To: <20030113215318.GA278@crow.dom2ip.de>
References:  <20030113173957.T73725@levais.imp.ch> <20030113215318.GA278@crow.dom2ip.de>

next in thread | previous in thread | raw e-mail | index | archive | help

Hi Thomas,

>  	s = splnet();
> +	if (so->so_state & (SS_ISCONNECTED | SS_ISCONNECTING)) {
> +		splx(s);
> +		return (EINVAL);
> +	}
>  	error = (*so->so_proto->pr_usrreqs->pru_listen)(so, td);
>  	if (error) {
>  		splx(s);
>

Can you commit this ? The fix looks appropriate, but the manpage should
also be changed to reflect the change.

ERRORS
     Listen() will fail if:

     [EBADF]            The argument s is not a valid descriptor.
     [ENOTSOCK]         The argument s is not a socket.
     [EOPNOTSUPP]       The socket is not of a type that
			supports the operation listen().
     [EINVAL]		Listen() has been already called on the socket.

Any objections from others ?

Martin

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030114100620.W76016>