Date: Mon, 20 Apr 2009 11:37:53 +0100 (BST) From: Robert Watson <rwatson@FreeBSD.org> To: Bruce Evans <brde@optusnet.com.au> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r191292 - head/libexec/rtld-elf Message-ID: <alpine.BSF.2.00.0904201135470.71062@fledge.watson.org> In-Reply-To: <20090420171843.A58020@delplex.bde.org> References: <200904192303.n3JN3v9w023289@svn.freebsd.org> <20090420171843.A58020@delplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 20 Apr 2009, Bruce Evans wrote: >> Explicitly include machine/param.h for CACHE_LINE_SIZE. >> >> MFC after: 2 weeks >> >> Modified: >> head/libexec/rtld-elf/rtld_lock.c > > It is a style bug (unwarranted chumminess with the implementation) to > include (or otherwise refer to) machine/param.h directly in *.c. This is > only the 5th instance of this style bug in all of /usr/src. The previous > ones are: I think rtld would count as part of "the implementation" from most perspectives, but I agree, and have made the change :-). Robert N M Watson Computer Laboratory University of Cambridge
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.0904201135470.71062>