Date: Wed, 03 Jun 2026 07:10:45 +0000 From: Navdeep Parhar <np@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: 4b6887e38638 - main - cxgbe(4): Do not read indirect INT_CAUSE registers directly Message-ID: <6a1fd375.332ab.c3e63af@gitrepo.freebsd.org>
index | next in thread | raw e-mail
The branch main has been updated by np: URL: https://cgit.FreeBSD.org/src/commit/?id=4b6887e3863881ff3be447c00fa2ae0c563550c5 commit 4b6887e3863881ff3be447c00fa2ae0c563550c5 Author: Navdeep Parhar <np@FreeBSD.org> AuthorDate: 2026-06-01 23:36:36 +0000 Commit: Navdeep Parhar <np@FreeBSD.org> CommitDate: 2026-06-03 06:36:34 +0000 cxgbe(4): Do not read indirect INT_CAUSE registers directly Some of the registers added in a172f9e5b3cf are not directly accessible and should be avoided. Fixes: a172f9e5b3cf cxgbe(4): Improvements to the slow interrupt handler MFC after: 1 week Sponsored by: Chelsio Communications --- sys/dev/cxgbe/common/t4_hw.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sys/dev/cxgbe/common/t4_hw.c b/sys/dev/cxgbe/common/t4_hw.c index 41606201ad39..1386ae1767fd 100644 --- a/sys/dev/cxgbe/common/t4_hw.c +++ b/sys/dev/cxgbe/common/t4_hw.c @@ -6610,6 +6610,7 @@ static bool pmtx_intr_handler(struct adapter *adap, int arg, int flags) .details = NULL, .actions = pmtx_int_cause_actions, }; +#ifdef notyet static const struct intr_details pmtx_perr_cause_details[] = { { F_ICSPI_OVFL, "icspi FIFO Overflow" }, { F_OSPI_OVERFLOW3_TX, " OSPI overflow on channel 3 error." }, @@ -6641,6 +6642,7 @@ static bool pmtx_intr_handler(struct adapter *adap, int arg, int flags) .details = pmtx_perr_cause_details, .actions = NULL, }; +#endif bool fatal; if (chip_id(adap) >= CHELSIO_T7) @@ -6648,8 +6650,10 @@ static bool pmtx_intr_handler(struct adapter *adap, int arg, int flags) else pmtx_int_cause.details = pmtx_int_cause_fields; fatal = t4_handle_intr(adap, &pmtx_int_cause, 0, flags); +#ifdef notyet if (chip_id(adap) >= CHELSIO_T7) fatal |= t4_handle_intr(adap, &pmtx_perr_cause, 0, flags); +#endif clear_int_cause_reg(adap, &pmtx_int_cause, flags); return (fatal); @@ -6705,6 +6709,7 @@ static bool pmrx_intr_handler(struct adapter *adap, int arg, int flags) .details = NULL, .actions = NULL, }; +#ifdef notyet static const struct intr_details pm_rx_int_cause_2_details[] = { { F_CACHE_SRAM_ODD_CERR, "Cache Data Odd SRAM Correctable Error" }, { F_CACHE_SRAM_EVEN_CERR, "Cache Data Even SRAM Correctable Error" }, @@ -6766,13 +6771,16 @@ static bool pmrx_intr_handler(struct adapter *adap, int arg, int flags) .details = pm_rx_perr_cause_details, .actions = NULL, }; +#endif bool fatal; if (chip_id(adap) >= CHELSIO_T7) { pmrx_int_cause.details = t7_pmrx_int_cause_fields; fatal = t4_handle_intr(adap, &pmrx_int_cause, 0, flags); +#ifdef notyet fatal |= t4_handle_intr(adap, &pmrx_int_cause2, 0, flags); fatal |= t4_handle_intr(adap, &pmrx_perr_cause, 0, flags); +#endif } else { pmrx_int_cause.details = pmrx_int_cause_fields; fatal = t4_handle_intr(adap, &pmrx_int_cause, 0, flags);home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6a1fd375.332ab.c3e63af>