Date: Tue, 28 Apr 2026 21:21:40 +0200 From: Daniel Engberg <diizzy@FreeBSD.org> To: Gleb Popov <arrowd@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 70718cbf1b00 - main - Mk/Uses/meson.mk: Silence warning during do-configure stage Message-ID: <66ff8588-89bb-49ec-a208-7a7d3e2e42b7@FreeBSD.org> In-Reply-To: <CALH631nrefU_s_rJ%2B-ChEzR1SVbmF7K8nDrO7wNKk4_8u-5uOw@mail.gmail.com> References: <69f0fbce.202f4.25de3156@gitrepo.freebsd.org> <CALH631nrefU_s_rJ%2B-ChEzR1SVbmF7K8nDrO7wNKk4_8u-5uOw@mail.gmail.com>
index | next in thread | previous in thread | raw e-mail
On 2026-04-28 20:50, Gleb Popov wrote: > On Tue, Apr 28, 2026 at 9:26 PM Daniel Engberg <diizzy@freebsd.org> wrote: >> >> PR: 294808 >> Reviewed by: desktop (arrowd), previous interation > > desktop@ did not give you approval on this iteration, nor approved > bf193dc1da282c769d3291817a8378adbd762ac7 and you didn't wait even 3 > days to give me a chance to review this. > > But I'm too tired to fight you, so I'm letting portmgr to chime in if > they are interested. Hi, The only difference is that the framework will now throw an error when Meson ports are using CONFIGURE_ARGS for passing actual MESON_ARGS which is incorrect as stated by Porters Handbook and Mk/Uses/meson.mk (and not breaking things). Which is what I assumed (being naive) the first time didn't occur in tree and I managed to cherry pick ports that didn't (to be fair, only a handful out of 1000+ do). https://docs.freebsd.org/en/books/porters-handbook/book/#using-meson https://cgit.freebsd.org/ports/tree/Mk/Uses/meson.mk#n15 Additionally there are no PRs or open reviews on reviews.freebsd.org or other documentation claiming otherwise at least that I can find. Building ~2000+ ports later (in total) I can't find more ports violating this or failing. bf193dc1da282c769d3291817a8378adbd762ac7 falls under blanket https://docs.freebsd.org/en/articles/committers-guide/#ports-qa-misc-blanket-approval In hindsight, I should've built the all meson from the start but that takes a day or so even on a fairly beefy box. Best regards, Danielhome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?66ff8588-89bb-49ec-a208-7a7d3e2e42b7>