Date: Tue, 4 Apr 2017 15:37:52 +0300 From: Andrey Chernov <ache@freebsd.org> To: Kyle Evans <kevans91@ksu.edu> Cc: Ed Maste <emaste@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r316477 - head/usr.bin/grep Message-ID: <9018c8db-2a89-c8b2-750b-fe11ac08333f@freebsd.org> In-Reply-To: <CACNAnaGMv0WGO0MjnJwrYTdZhutoU7qPbzkiCS2zi2wnCKV=ZQ@mail.gmail.com> References: <201704032316.v33NGpbo037305@repo.freebsd.org> <4ceb1a18-3a72-c0e3-b2e2-f71d687cd153@freebsd.org> <CACNAnaGMv0WGO0MjnJwrYTdZhutoU7qPbzkiCS2zi2wnCKV=ZQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 04.04.2017 15:24, Kyle Evans wrote: > On Tue, Apr 4, 2017 at 7:07 AM, Andrey Chernov <ache@freebsd.org > <mailto:ache@freebsd.org>> wrote: > > On 04.04.2017 2:16, Ed Maste wrote: > > if (color) > > - fprintf(stdout, "\33[m\33[K"); > > + fprintf(stdout, "\33[00m\33[K"); > > Please back that one out. We don't need to handle internally or print > remotely excessive 00. > At least according to > https://en.wikipedia.org/wiki/ANSI_escape_code > <https://en.wikipedia.org/wiki/ANSI_escape_code>; > "With no parameters, CSI m is treated as CSI 0 m (reset / normal), which > is typical of most of the ANSI escape sequences." > > > Hi ache@, > > This specific change was made in the name of explicitly matching colored > output of GNU grep for simplification of regression test purposes, > rather than for good form. Is it still unacceptable to do so? IMHO everyday usage by everyone weights much more than occasional regression tests run which can be fixed instead of this place. F.e. we already do a lot of local fixes in the NetBSD regression tests instead of pretending to mimic NetBSD in 100% in the system itself.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9018c8db-2a89-c8b2-750b-fe11ac08333f>