Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 21 Feb 2001 16:42:01 +0100 (CET)
From:      Christian Weisgerber <naddy@mips.inka.de>
To:        FreeBSD-gnats-submit@freebsd.org
Subject:   kern/25254: devfs uses obsolete sa(4) device names
Message-ID:  <200102211542.f1LFg1N02718@kemoauc.mips.inka.de>
next in thread | raw e-mail | index | archive | help 


>Number:         25254
>Category:       kern
>Synopsis:       devfs uses obsolete sa(4) device names
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Feb 21 07:50:01 PST 2001
>Closed-Date:
>Last-Modified:
>Originator:     Christian Weisgerber
>Release:        FreeBSD 5.0-CURRENT alpha
>Organization:
>Environment:
System: FreeBSD kemoauc.mips.inka.de 5.0-CURRENT FreeBSD 5.0-CURRENT #1: Wed Feb 21 15:14:11 CET 2001 naddy@kemoauc.mips.inka.de:/usr/src/sys/compile/KEMOAUC alpha

>Description:

devfs uses an obsolete set of SCSI tape device names:
    rsaN.ctl, rsaN*, nrsaN*, ersaN*

Some time ago the tape device names were brought in line with the
other devices and the 'r' (for "raw device") was stripped:
    saN.ctl, saN*, nsaN*, esaN*
devfs should follow this convention as well.

Also see the sa(4) man page.

>How-To-Repeat:

>Fix:

--- sys/cam/scsi/scsi_sa.c.orig	Wed Feb 21 14:52:38 2001
+++ sys/cam/scsi/scsi_sa.c	Wed Feb 21 14:53:46 2001
@@ -1467,24 +1467,24 @@
 
 	softc->devs.ctl_dev = make_dev(&sa_cdevsw, SAMINOR(SA_CTLDEV,
 	    periph->unit_number, 0, SA_ATYPE_R), UID_ROOT, GID_OPERATOR,
-	    0660, "r%s%d.ctl", periph->periph_name, periph->unit_number);
+	    0660, "%s%d.ctl", periph->periph_name, periph->unit_number);
 
 	for (i = 0; i < SA_NUM_MODES; i++) {
 
 		softc->devs.mode_devs[i].r_dev = make_dev(&sa_cdevsw,
 		    SAMINOR(SA_NOT_CTLDEV, periph->unit_number, i, SA_ATYPE_R),
-		    UID_ROOT, GID_OPERATOR, 0660, "r%s%d.%d",
+		    UID_ROOT, GID_OPERATOR, 0660, "%s%d.%d",
 		    periph->periph_name, periph->unit_number, i);
 
 		softc->devs.mode_devs[i].nr_dev = make_dev(&sa_cdevsw,
 		    SAMINOR(SA_NOT_CTLDEV, periph->unit_number, i, SA_ATYPE_NR),
-		    UID_ROOT, GID_OPERATOR, 0660, "nr%s%d.%d",
+		    UID_ROOT, GID_OPERATOR, 0660, "n%s%d.%d",
 		    periph->periph_name, periph->unit_number, i);
 
 
 		softc->devs.mode_devs[i].er_dev = make_dev(&sa_cdevsw,
 		    SAMINOR(SA_NOT_CTLDEV, periph->unit_number, i, SA_ATYPE_ER),
-		    UID_ROOT, GID_OPERATOR, 0660, "er%s%d.%d",
+		    UID_ROOT, GID_OPERATOR, 0660, "e%s%d.%d",
 		    periph->periph_name, periph->unit_number, i);
 
 		/*
@@ -1492,11 +1492,11 @@
 		 */
 		if (i == 0) {
 			make_dev_alias(softc->devs.mode_devs[i].r_dev,
-			   "r%s%d", periph->periph_name, periph->unit_number);
+			    "%s%d", periph->periph_name, periph->unit_number);
 			make_dev_alias(softc->devs.mode_devs[i].nr_dev,
-			    "nr%s%d", periph->periph_name, periph->unit_number);
+			    "n%s%d", periph->periph_name, periph->unit_number);
 			make_dev_alias(softc->devs.mode_devs[i].er_dev,
-			    "er%s%d", periph->periph_name, periph->unit_number);
+			    "e%s%d", periph->periph_name, periph->unit_number);
 		}
 	}
 
>Release-Note:
>Audit-Trail:
>Unformatted:

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200102211542.f1LFg1N02718>