Date: Mon, 8 Jul 2013 15:13:22 -0700 From: Garrett Cooper <yaneurabeya@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: svn-src-head <svn-src-head@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, src-committers <src-committers@freebsd.org>, shahark@mellanox.com Subject: Re: svn commit: r253048 - in head/sys/ofed: drivers/net/mlx4 include/linux Message-ID: <3FF894D3-ACDF-4796-A682-F9F9DD8C943D@gmail.com> In-Reply-To: <201307082125.r68LPDlY023493@svn.freebsd.org> References: <201307082125.r68LPDlY023493@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jul 8, 2013, at 2:25 PM, John Baldwin wrote: > Author: jhb > Date: Mon Jul 8 21:25:12 2013 > New Revision: 253048 > URL: http://svnweb.freebsd.org/changeset/base/253048 >=20 > Log: > Allow mlx4 devices to switch from Ethernet to Infiniband (and vice = versa): > - Fix sysctl wrapper for sysfs attributes to properly handle new = string > values similar to sysctl_handle_string() (only copyin the user's > supplied length and nul-terminate the string). > - Don't check for a trailing newline when evaluating the desired = operating > mode of a mlx4 device. >=20 > PR: kern/179999 > Submitted by: Shahar Klein <shahark@mellanox.com> > MFC after: 1 week Was there an issue with the patch I submitted via = http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dkern/174213 (basically = solving the same problem, but only with the sysfs <-> sysctl(9) = handler)? I was of the impression that sysfs on Linux always added on = trailing newlines (but I could be wrong because I haven't used Linux at = a dev level for ages). Thanks!=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3FF894D3-ACDF-4796-A682-F9F9DD8C943D>