Date: Tue, 22 May 2001 06:20:04 -0700 (PDT) From: Bruce Evans <bde@zeta.org.au> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/27480: [PATCH] fixes to jot(1) from OpenBSD Message-ID: <200105221320.f4MDK4617675@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/27480; it has been noted by GNATS. From: Bruce Evans <bde@zeta.org.au> To: dd@FreeBSD.ORG Cc: FreeBSD-gnats-submit@FreeBSD.ORG Subject: Re: bin/27480: [PATCH] fixes to jot(1) from OpenBSD Date: Tue, 22 May 2001 23:14:16 +1000 (EST) > The attached patch fixes some overflows in jot(1) and syncs up to > OpenBSD a little. Significant changes include: > > - use getopt > - de-register > - fix overflows in -b and -w options; old behavior: >... > - use strlcpy and snprintf > - check return values of the above > - fix other gratuituos diffs to OpenBSD; not a complete sync, > but better than nothing I would prefer to see the cleanups separately. Especially the getopt changes which merge getargs() into main() and rename av to argv. > I've sent this to -audit; it elicited comments about breaking K&R, > which I addressed, but no solid reviews. I noticed only a couple of minor style problems (similar to ones in the original code). You've done more than enough time as a ports-only (?) committer and should commit things more directly. Reviews are good of course if you can get them promptly. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200105221320.f4MDK4617675>