Date: Mon, 22 Jan 2018 19:24:27 +0000 From: "Poul-Henning Kamp" <phk@phk.freebsd.dk> To: John Baldwin <jhb@freebsd.org> Cc: Emmanuel Vadot <manu@bidouilliste.com>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r328257 - in head/sys: arm/broadcom/bcm2835 dts/arm modules Message-ID: <89102.1516649067@critter.freebsd.dk> In-Reply-To: <52374125.OgxafgljNu@ralph.baldwin.cx> References: <201801220710.w0M7AUm9091853@repo.freebsd.org> <88258.1516630050@critter.freebsd.dk> <20180122153003.664e1613bbf70ab49c5c1541@bidouilliste.com> <52374125.OgxafgljNu@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
-------- In message <52374125.OgxafgljNu@ralph.baldwin.cx>, John Baldwin writes: >Create the corresponding device_t but device_disable() it when there >is a disabled property. That also removes a couple of boilerplate lines from all FDT device drivers. >A user can then use 'devctl enable <blah>' to enable >it before (or even after) loading a device driver. That would work for me. I wonder if it would be too noisy if we allowed ->probe() to run on disabled devices and reported something like: "foobar0: Matched disabled device <...>" (without calling ->attach()) That way you would know you loaded the right driver, rather than have to guess. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?89102.1516649067>