Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 22 Jan 2002 01:15:31 +0300
From:      "Andrey A. Chernov" <ache@nagual.pp.ru>
To:        markm@freebsd.org, current@freebsd.org
Subject:   OPIE little speedup patch for review
Message-ID:  <20020121221530.GA44147@nagual.pp.ru>

next in thread | raw e-mail | index | archive | help
memset() in opiechallenge() really is not needed because it is the very
first thing opielookup() does being entered, i.e. look at this:

int opielookup FUNCTION((opie, principal), struct opie *opie AND char *principal)
{
  int i;

  memset(opie, 0, sizeof(struct opie));
...

And then the patch included:

--- challenge.c.bak	Tue Apr 11 16:52:01 2000
+++ challenge.c	Tue Jan 22 01:07:06 2002
@@ -52,8 +52,6 @@
 {
   int rval = -1;
 
-  memset(mp, 0, sizeof(*mp));
-
   rval = opielookup(mp, name);
 #if DEBUG
   if (rval) syslog(LOG_DEBUG, "opiechallenge: opielookup(mp, name=%s) returned %d", name, rval);

-- 
Andrey A. Chernov
http://ache.pp.ru/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020121221530.GA44147>