Date: Sun, 28 Jul 2002 20:47:29 +0300 From: Ruslan Ermilov <ru@FreeBSD.ORG> To: cyrille.lefevre@laposte.net, freebsd-stable@FreeBSD.ORG Subject: Re: buildworld objdir moved! (was Re: sys/boot) Message-ID: <20020728174729.GB28493@sunbay.com> In-Reply-To: <20020727151708.GA30397@gits.dyndns.org> References: <20020727145030.GA20412@gits.dyndns.org> <20020727151708.GA30397@gits.dyndns.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Sat, Jul 27, 2002 at 05:17:08PM +0200, Cyrille Lefevre wrote:
> On Sat, Jul 27, 2002 at 04:50:30PM +0200, Cyrille Lefevre wrote:
> > I'm running -stable and I encounter the following problem :
> >
> > # make buildworld
> > ...
> > ===> sys/boot/buildworld
> > cd: can't cd to /disk2/freebsd/stable/src/sys/boot/buildworld
> > *** Error code 2
>
> found it! this is due by recent changes in src/Makefile.inc1.
>
> TARGET is set using ?= and this is a problem when this variable
> already exists in the environment as I do through the Makefile
> I use to fetch/update/build/install/configure everything.
>
TARGET was set like this in RELENG_4 since an least revision
1.141.2.40, and the recent "problem" is that MAKEOBJDIRPREFIX
is now set based on TARGET instead of TARGET_ARCH, to make it
possible to cross-build/release pc98 on i386.
> here is the log before w/ the following patch :
> --------------------------------------------------------------
> >>> Rebuilding the temporary build tree
> --------------------------------------------------------------
> # XXX - These two can depend on any header file.
> rm -f /usr/obj/buildworld/disk2/freebsd/stable/src/usr.bin/kdump/ioctl.c
> rm -f /usr/obj/buildworld/disk2/freebsd/stable/src/usr.bin/truss/ioctl.c
> ^^^^^^^^^^ oops!
>
> and the log w/ it :
> --------------------------------------------------------------
> >>> Rebuilding the temporary build tree
> --------------------------------------------------------------
> # XXX - These two can depend on any header file.
> rm -f /usr/obj/disk2/freebsd/stable/src/usr.bin/kdump/ioctl.c
> rm -f /usr/obj/disk2/freebsd/stable/src/usr.bin/truss/ioctl.c
>
> Index: /usr/src/Makefile.inc1
> ===================================================================
> RCS file: /home/ncvs/src/Makefile.inc1,v
> retrieving revision 1.141.2.54
> diff -u -r1.141.2.54 Makefile.inc1
> --- /usr/src/Makefile.inc1 25 Jul 2002 09:33:13 -0000 1.141.2.54
> +++ /usr/src/Makefile.inc1 27 Jul 2002 15:04:17 -0000
> @@ -126,9 +126,12 @@
> MAKEOBJDIRPREFIX?= /usr/obj
> TARGET_ARCH?= ${MACHINE_ARCH}
> .if ${TARGET_ARCH} == ${MACHINE_ARCH}
> -TARGET?= ${MACHINE}
> +TARGET= ${MACHINE}
> .else
> -TARGET?= ${TARGET_ARCH}
> +TARGET= ${TARGET_ARCH}
> +.endif
> +.if defined(TARGET_OVERRIDE)
> +TARGET= ${TARGET_OVERRIDE}
> .endif
> .if make(buildworld)
> BUILD_ARCH!= sysctl -n hw.machine_arch
>
No thanks, please fix your scripts instead. :-)
> PS : the previous patch submitted still apply.
>
I will address this later, when we finished our makefile.style(7).
The following makefiles also have this SUBDIR assignment problem:
gnu/lib/libregex/Makefile
gnu/usr.bin/binutils/as/Makefile
gnu/usr.bin/diff/Makefile
gnu/usr.bin/grep/Makefile
gnu/usr.bin/send-pr/Makefile
lib/libpam/Makefile
sys/boot/Makefile
sys/modules/lomac/Makefile
tools/regression/geom/Makefile
tools/regression/geom/Test/Makefile
usr.bin/bzip2/Makefile
Cheers,
--
Ruslan Ermilov Sysadmin and DBA,
ru@sunbay.com Sunbay Software AG,
ru@FreeBSD.org FreeBSD committer,
+380.652.512.251 Simferopol, Ukraine
http://www.FreeBSD.org The Power To Serve
http://www.oracle.com Enabling The Information Age
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (FreeBSD)
iD8DBQE9RC4xUkv4P6juNwoRAi9sAJ0XnKG9Gpy8YS0xsYJQ5mVfiEY+vACfUJRP
4tJXW5C+AlhfBj3GNnM8uHs=
=UfP/
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020728174729.GB28493>