Date: Sun, 12 Nov 1995 10:03:10 -0800 From: David Greenman <davidg@Root.COM> To: ache@astral.msk.su Cc: Peter Wemm <peter@jhome.dialix.com>, CVS-commiters@freefall.freebsd.org, security@freebsd.org Subject: Re: cvs commit: CVSROOT log_accum.pl Message-ID: <199511121803.KAA02195@corbin.Root.COM> In-Reply-To: Your message of "Sun, 12 Nov 95 16:30:08 %2B0300." <jCWRVfmqE0@ache.dialup.demos.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
>In message <Pine.BSF.3.91.951103212121.283A-100000@jhome.DIALix.COM>
> Peter Wemm writes:
>
>>I'm running a variant of what you proposed in my kernel at the moment..
>> if (!SESS_LEADER(p))
>> printf("setlogin called from a non session leader, pid %d\n", p->p_pid);
>
>>I do not doubt that your fix is a "good thing" and will be required sooner
>>or later, I just want to make sure we are not going to to have a hundred
>>bug reports "xdm doesn't work any more" or some other program that we're
>>not aware of yet.
>
>Peter, do you have any progress in this issue for now?
>Maybe it is time to commit my fix to -current?
If we decide to change setlogin() so that it only works for session
leaders, then I'd prefer that we leave out the printf(). If you want to add
that to your own sources, fine, but I prefer to keep console noise minimized
to important failures.
-DG
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199511121803.KAA02195>