Date: Tue, 28 Jun 2005 01:45:51 -0400 (EDT) From: "David D.W. Downey" <pgpkeys@pgpnet.us> To: FreeBSD-gnats-submit@FreeBSD.org Subject: bin/82720: <[patch] Incorrect help output from growfs.c and mkfs.c> Message-ID: <200506280545.j5S5jp26022268@www.pgpkeys.us> Resent-Message-ID: <200506280550.j5S5oDU1024209@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 82720
>Category: bin
>Synopsis: <[patch] Incorrect help output from growfs.c and mkfs.c>
>Confidential: no
>Severity: serious
>Priority: high
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Jun 28 05:50:13 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: David D.W. Downey
>Release: FreeBSD 5.4-RELEASE-p1 i386
>Organization:
<CyberSpace Technologies>
>Environment:
System: FreeBSD www.pgpkeys.us 5.4-RELEASE-p1 FreeBSD 5.4-RELEASE-p1 #0: Sun Jun 26 08:14:43 EDT 2005 root@www.pgpkeys.us:/usr/obj/usr/src/sys/PGPNET i386
Duron 1.3GHz + 1GB DDR266 RAM
>Description:
newfs -N incorrectly states that, when passing superblocks for filesystem repair, fsck -b is the action for specifying the superblock to repair a filesystem as shown by the following output.
OUTPUT
-------
/dev/ad0s1a: 9000.0MB (18432000 sectors) block size 16384, fragment size 2048
using 49 cylinder groups of 183.77MB, 11761 blks, 23552 inodes.
super-block backups (for fsck -b #) at:
<snip>
-----------
END OUTPUT
The correct information is 'fsck_ffs -b #' for specifying this information. I have submitted 2 patches to repair the 2 files involved with displaying this incorrect information. The files involved are /usr/src/sbin/growfs/growfs.c and /usr/src/sbin/newfs/mkfs.c
>How-To-Repeat:
log in as uid 0 and run 'newfs -N /dev/<SomeMountDevice>'
>Fix:
Apply the patches below.
Commit changes.
--- growfs.c-062820050018 begins here ---
--- growfs.c Thu Jul 29 07:28:24 2004
+++ growfs.c-fixed Tue Jun 28 00:17:48 2005
@@ -252,7 +252,7 @@
* Now build the cylinders group blocks and
* then print out indices of cylinder groups.
*/
- printf("super-block backups (for fsck -b #) at:\n");
+ printf("super-block backups (for fsck_ffs -b #) at:\n");
i = 0;
width = charsperline();
--- growfs.c-062820050018 ends here ---
--- mkfs.c-062820050021 begins here ---
--- mkfs.c Tue Mar 1 00:30:30 2005
+++ mkfs.c-fixed Tue Jun 28 00:20:41 2005
@@ -477,7 +477,7 @@
* Now build the cylinders group blocks and
* then print out indices of cylinder groups.
*/
- printf("super-block backups (for fsck -b #) at:\n");
+ printf("super-block backups (for fsck_ffs -b #) at:\n");
i = 0;
width = charsperline();
/*
--- mkfs.c-062820050021 ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200506280545.j5S5jp26022268>