Date: Wed, 29 Jun 2005 00:23:38 -0700 From: Brooks Davis <brooks@one-eyed-alien.net> To: Darren Pilgrim <dmp@bitfreak.org> Cc: current@freebsd.org Subject: Re: dhclient/wpa_supplicant patch Message-ID: <20050629072338.GB24309@odin.ac.hmc.edu> In-Reply-To: <001201c57c6e$fcb87140$0b2a15ac@SMILEY> References: <20050629053335.GA18808@odin.ac.hmc.edu> <001201c57c6e$fcb87140$0b2a15ac@SMILEY>
next in thread | previous in thread | raw e-mail | index | archive | help
--Yylu36WmvOXNoKYn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 28, 2005 at 10:54:15PM -0700, Darren Pilgrim wrote: > From: Brooks Davis > >=20 > > --- rc.d/wpa_supplicant Tue Jun 28 22:24:18 2005 > > +++ rc.d/wpa_supplicant Tue Jun 28 18:51:32 2005 > <...> > > +if ! wpaif $ifn; then > > + return 1 > > +fi >=20 > I think it would be better if the dhcpif/wpaif test is contained within > netif. It has to exist in netif because its job is to determine how to > configure the interface. The dhclient and wpa_supplicant scripts should > be "dumb" single-task scripts to start/stop their respective clients. >=20 > By putting the dhcpif/wpaif test in the dhclient/wpa_supplicant scripts, > not only is it redundant, it makes it impossible to use the scripts > manually with an interface that isn't configured in /etc/rc.conf with > the DHCP or WPA magic words. Such manual operations are useful in > testing, temporary interfaces and custom profile-based configurations > where it's not possible/practical to have a configuration line in > /etc/rc.conf beforehand. Good point. The test is already in ifconfig_up/down so it's not needed in wpa_supplicant or dhclient. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --Yylu36WmvOXNoKYn Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFCwkx5XY6L6fI4GtQRAgM+AKC4v4Gb3FGCeFkxLArI72bP4y9zQgCffaYp +f6C6E2tuc9j1lDBo9sn/84= =RtDl -----END PGP SIGNATURE----- --Yylu36WmvOXNoKYn--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050629072338.GB24309>