Date: Tue, 16 Sep 2003 17:02:19 +0200 From: Thomas Quinot <thomas@cuivre.fr.eu.org> To: deischen@freebsd.org Cc: current@freebsd.org Subject: Re: scsi_cd or atapicam crash in current. Message-ID: <20030916150218.GB62176@melusine.cuivre.fr.eu.org> In-Reply-To: <Pine.GSO.4.10.10309161044002.10005-100000@pcnet5.pcnet.com> References: <20030916121916.GB47779@melusine.cuivre.fr.eu.org> <Pine.GSO.4.10.10309161044002.10005-100000@pcnet5.pcnet.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--aVD9QWMuhilNxW9f
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Le 2003-09-16, Daniel Eischen =E9crivait :
> I get this even without atapicam in the kernel. Is trying
> CAMDEBUG and CAM_DEBUG_CDB going to show anything interesting?
No, indeed, probably not. Can you try the following patch:
Index: ata-lowlevel.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /home/ncvs/src/sys/dev/ata/ata-lowlevel.c,v
retrieving revision 1.11
diff -u -r1.11 ata-lowlevel.c
--- ata-lowlevel.c 10 Sep 2003 09:57:16 -0000 1.11
+++ ata-lowlevel.c 16 Sep 2003 15:00:13 -0000
@@ -374,6 +374,11 @@
=20
/* ATAPI PIO commands */
case ATA_R_ATAPI:
+ if (request->status & (ATA_S_ERROR | ATA_S_DWF)) {
+ request->error =3D ATA_IDX_INB(ch, ATA_ERROR);
+ break;
+ }
+
length =3D ATA_IDX_INB(ch, ATA_CYL_LSB)|(ATA_IDX_INB(ch, ATA_CYL_MSB)<<8);
=20
switch ((ATA_IDX_INB(ch, ATA_IREASON) & (ATA_I_CMD | ATA_I_IN)) |
@@ -446,8 +451,6 @@
=20
case ATAPI_P_ABORT:
case ATAPI_P_DONE:
- if (request->status & (ATA_S_ERROR | ATA_S_DWF))
- request->error =3D ATA_IDX_INB(ch, ATA_ERROR);
break;
=20
default:
--=20
Thomas.Quinot@Cuivre.FR.EU.ORG
--aVD9QWMuhilNxW9f
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (FreeBSD)
iD8DBQE/ZyX5AE1UuDk9JGkRAkxcAJ45smameys9W4gkXAY7ePz6H5gUewCfTE5C
UUyUTWQ0aDfsoRyaPJsY8fk=
=qD8I
-----END PGP SIGNATURE-----
--aVD9QWMuhilNxW9f--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030916150218.GB62176>