Date: Thu, 26 Feb 2009 15:51:54 +0000 (UTC) From: Ed Schouten <ed@FreeBSD.org> To: cvs-src-old@freebsd.org Subject: cvs commit: src/sys/kern kern_exec.c kern_exit.c kern_malloc.c kern_rwlock.c kern_sig.c kern_synch.c kern_thr.c kern_time.c tty_info.c Message-ID: <200902261552.n1QFq6PF089250@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
ed 2009-02-26 15:51:54 UTC FreeBSD src repository Modified files: sys/kern kern_exec.c kern_exit.c kern_malloc.c kern_rwlock.c kern_sig.c kern_synch.c kern_thr.c kern_time.c tty_info.c Log: SVN rev 189074 on 2009-02-26 15:51:54Z by ed Remove even more unneeded variable assignments. kern_time.c: - Unused variable `p'. kern_thr.c: - Variable `error' is always caught immediately, so no reason to initialize it. There is no way that error != 0 at the end of create_thread(). kern_sig.c: - Unused variable `code'. kern_synch.c: - `rval' is always assigned in all different cases. kern_rwlock.c: - `v' is always overwritten with RW_UNLOCKED further on. kern_malloc.c: - `size' is always initialized with the proper value before being used. kern_exit.c: - `error' is always caught and returned immediately. abort2() never returns a non-zero value. kern_exec.c: - `len' is always assigned inside the if-statement right below it. tty_info.c: - `td' is always overwritten by FOREACH_THREAD_IN_PROC(). Found by: LLVM's scan-build Revision Changes Path 1.328 +0 -3 src/sys/kern/kern_exec.c 1.318 +0 -2 src/sys/kern/kern_exit.c 1.169 +0 -2 src/sys/kern/kern_malloc.c 1.43 +0 -1 src/sys/kern/kern_rwlock.c 1.367 +1 -5 src/sys/kern/kern_sig.c 1.318 +0 -1 src/sys/kern/kern_synch.c 1.74 +1 -3 src/sys/kern/kern_thr.c 1.146 +0 -2 src/sys/kern/kern_time.c 1.5 +0 -1 src/sys/kern/tty_info.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200902261552.n1QFq6PF089250>