Date: Wed, 1 Apr 2015 09:08:53 +0200 (CEST) From: sg-ball@laposte.net To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: freebsd-pkg@freebsd.org Subject: Re: Problem with pkg behind a chunking proxy Message-ID: <2106067877.31883344.1427872133869.JavaMail.zimbra@laposte.net> In-Reply-To: <20150331223320.GJ30115@ivaldir.etoilebsd.net> References: <902242756.31277524.1427836544530.JavaMail.zimbra@laposte.net> <1476070491.31317997.1427838521190.JavaMail.zimbra@laposte.net> <20150331223320.GJ30115@ivaldir.etoilebsd.net>
next in thread | previous in thread | raw e-mail | index | archive | help
I could join to GitHub, fork pkg and commit the patch to my fork (https://github.com/sg-ball/pkg), but it is still untested and I wonder if the display "file: 0%" that directly goes to 100% is acceptable. Anyway, thanks for you quick anwser Serge ----- Mail original ----- De: "Baptiste Daroussin" <bapt@FreeBSD.org> À: sg-ball@laposte.net Cc: freebsd-pkg@freebsd.org Envoyé: Mercredi 1 Avril 2015 00:33:20 Objet: Re: Problem with pkg behind a chunking proxy > ... > I think this feature could be interesting since Transfer-Encoding: chunked is valid as HTTP 1.1 but I'm not used to submitting patches even if I've been using FreeBSD since release 3.x ... So usually the feature should be discussed in pkg@FreeBSD.org or in #pkgng (freenode) or on github issue, I have to confess that I do track more often github issue tracker than freebsd's bugzilla for pkg related issues. (which is bad I should more track both). Concerning your feature it is very welcome :) usually we do like pull request on github. Note that you are just in time for pkg 1.5 which will be released soon :) The preferred way is usually pull request, but I'm flexible if the submitter is anti github then I can just grab patches. That part of the code hasn't been modified since pkg 1.4 so the patch should apply just fine. ... So as a conclusion first make a pull request on github, then once it is well tested enough you can provide a patch for base (or I'll do) if so open a ticket in the bug tracker for base and do not hesitate to harass me :) Thanks again, Bapt
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2106067877.31883344.1427872133869.JavaMail.zimbra>